fief-dev / fief

Users and authentication management SaaS
https://www.fief.dev
Other
488 stars 42 forks source link

added support for Docker secrets. #190

Closed oaltun closed 1 year ago

oaltun commented 1 year ago

This PR adds support for Docker secrets.

All environment variables can also be passed as Docker secrets.

To use docker secrets, for each Docker secret XXX, in a docker stack file we need to have lines like:

services:
  fief:
    image: ...
    secrets:
      - XXX

secrets:
    XXX:
      external: true

We also need to add the secret in the command line like:

printf "my super secret password" | docker secret create XXX -

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c7b99d6). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage        ?   93.21%           
=======================================
  Files           ?      234           
  Lines           ?     7958           
  Branches        ?        0           
=======================================
  Hits            ?     7418           
  Misses          ?      540           
  Partials        ?        0           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

frankie567 commented 1 year ago

@all-contributors add @oaltun for code

allcontributors[bot] commented 1 year ago

@frankie567

I've put up a pull request to add @oaltun! :tada:

oaltun commented 1 year ago

Great, thanks!