fief-dev / fief

Users and authentication management SaaS
https://www.fief.dev
Other
538 stars 44 forks source link

OpenAPI: default values for Client's lifetimes are misleading #213

Open frankie567 opened 1 year ago

frankie567 commented 1 year ago

Following #211 and #194, we found out that, by default, OpenAPI sets default values for authorization_code_lifetime_seconds, access_id_token_lifetime_seconds and refresh_token_lifetime_seconds to 0.

This is misleading because, as we've seen, developers can copy/paste the whole example payload and inadvertently set the token lifetime to zero.

We should tweak the Pydantic schema so OpenAPI shows more sensible values.

BTW, maybe we should reconsider the minimum validation for those values, which is currently 0.

Upvote & Fund

Fund with Polar