fief-dev / fief

Users and authentication management SaaS
https://www.fief.dev
Other
486 stars 42 forks source link

add password_min_length and password_min_score to settings #294

Closed yaroslaff closed 8 months ago

yaroslaff commented 8 months ago

This changes allows to configure lower password requirements. As other fief settings, this can be overriden from .env file or environment like:

PASSWORD_MIN_LENGTH=6
PASSWORD_MIN_SCORE=1
frankie567 commented 8 months ago

Thank you for those changes @yaroslaff!

Two things:

yaroslaff commented 8 months ago

Good idea, thanks! Added pydantic constraints and lint is happy now.

codecov[bot] commented 8 months ago

Codecov Report

Merging #294 (5093f4e) into main (868f9eb) will decrease coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   92.76%   92.72%   -0.04%     
==========================================
  Files         247      247              
  Lines        8731     8734       +3     
==========================================
  Hits         8099     8099              
- Misses        632      635       +3     
Files Coverage Δ
fief/services/password.py 100.00% <100.00%> (ø)
fief/settings.py 93.79% <100.00%> (+0.09%) :arrow_up:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

yaroslaff commented 8 months ago

Are MariaDB errors expected?

frankie567 commented 8 months ago

Good to go, thanks 🙏

@all-contributors add @yaroslaff for code

allcontributors[bot] commented 8 months ago

@frankie567

I've put up a pull request to add @yaroslaff! :tada:

frankie567 commented 8 months ago

Are MariaDB errors expected?

Happens sometimes, not relevant here 🙃