Closed yaroslaff closed 8 months ago
Thank you for those changes @yaroslaff!
Two things:
password_min_score
? The allowed values are 0, 1, 2, 3 and 4, so could be nice to have a constraint (ge=0, le=4
)hatch run lint
Good idea, thanks! Added pydantic constraints and lint is happy now.
Merging #294 (5093f4e) into main (868f9eb) will decrease coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #294 +/- ##
==========================================
- Coverage 92.76% 92.72% -0.04%
==========================================
Files 247 247
Lines 8731 8734 +3
==========================================
Hits 8099 8099
- Misses 632 635 +3
Files | Coverage Δ | |
---|---|---|
fief/services/password.py | 100.00% <100.00%> (ø) |
|
fief/settings.py | 93.79% <100.00%> (+0.09%) |
:arrow_up: |
... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Are MariaDB errors expected?
Good to go, thanks 🙏
@all-contributors add @yaroslaff for code
@frankie567
I've put up a pull request to add @yaroslaff! :tada:
Are MariaDB errors expected?
Happens sometimes, not relevant here 🙃
This changes allows to configure lower password requirements. As other fief settings, this can be overriden from .env file or environment like: