search

fief-dev / fief

Users and authentication management SaaS
https://www.fief.dev
Other
486 stars 42 forks source link

Check password strength in Quickstart CLI #305

Closed frankie567 closed 6 months ago

frankie567 commented 7 months ago

Discussed in https://github.com/orgs/fief-dev/discussions/304

Originally posted by **otailai** November 24, 2023 Here are my operation steps: 1. run command docker run -it --rm ghcr.io/fief-dev/fief:latest fief quickstart --docker, and then, I typed my email and password, after that, I got reponse in command line as following: `docker run \ --name fief-server \ -p 8000:8000 \ -d \ -e "SECRET=XXX" \ -e "FIEF_CLIENT_ID=XXX" \ -e "FIEF_CLIENT_SECRET=XXX" \ -e "ENCRYPTION_KEY=XXX" \ -e "PORT=8000" \ -e "ROOT_DOMAIN=localhost:8000" \ -e "FIEF_DOMAIN=localhost:8000" \ -e "FIEF_MAIN_USER_EMAIL=anne@bretagne.duchy" \ -e "FIEF_MAIN_USER_PASSWORD=XXX" \ -e "CSRF_COOKIE_SECURE=False" \ -e "SESSION_DATA_COOKIE_SECURE=False" \ -e "USER_LOCALE_COOKIE_SECURE=False" \ -e "LOGIN_SESSION_COOKIE_SECURE=False" \ -e "SESSION_COOKIE_SECURE=False" \ -e "FIEF_ADMIN_SESSION_COOKIE_SECURE=False" \ ghcr.io/fief-dev/fief:latest ` 2. I execute the docker command above, the feedback is good, the container is running: image Unfortunately, when I open the login page(http://localhost:8000/admin) in browser, something went run image So, I start to check the logs, found my password was too weak. image After re-running the docker start command, I get the correct feedback. My confusion is that maybe we can enhance the password inputing part, so our users won't debug anymore when they have such problems. Thank you.
otailai commented 7 months ago

good to know that, I am considering to use fief now, maybe one day I could be a commiter :)

ScottFred commented 7 months ago

@frankie567 I ran into this same issue when I was experimenting with Fief for the fist time. I just submitted a PR for this one. Let me know what you think. Thanks