Allow 127.0.0.1 as well for development - Githubissues

fief-dev / fief

Users and authentication management SaaS

https://www.fief.dev

Other

577 stars 48 forks source link

Allow 127.0.0.1 as well for development #39

Closed duber000 closed 2 years ago

duber000 commented 2 years ago

For those corner cases where localhost isn't able to be resolved to 127.0.0.1

frankie567 commented 2 years ago

Hi @duber000, welcome to Fief 👋

Thank you for this contribution, much appreciated 🙏 May I ask you to do two things?

[ ] Run black formatter
[ ] Add a unit test to check if 127.0.0.1 is accepted (you just have to add a case in the parametrize decorator): https://github.com/fief-dev/fief/blob/d950f240016a196d269518a968243a5e471571f2/backend/tests/test_apps_admin_clients.py#L113-L122
[ ] Tweak the regex the same way in the frontend validation: https://github.com/fief-dev/fief/blob/d950f240016a196d269518a968243a5e471571f2/admin-frontend/src/components/RedirectURISInput/RedirectURISInput.tsx#L10

frankie567 commented 2 years ago

Looks great! Thank tou @duber000 👍

@all-contributors add @duber000 for code

allcontributors[bot] commented 2 years ago

@frankie567

I've put up a pull request to add @duber000! :tada: