Closed ApprenticeofEnder closed 3 months ago
Thank you for this! Looks good 👍
I've fixed the pytest dependencies on the main branch; could you rebase your PR without the changes on pyproject.toml
?
That should work the same way, I wasn't able to figure out how to rebase it in a way that would selectively keep changes.
That'll do the trick :) For the record, you can achieve that using git rebase
.
@all-contributors add @ApprenticeofEnder for code
@frankie567
I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.
I've put up a pull request to add @ApprenticeofEnder! :tada:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.59%. Comparing base (
af65cd7
) to head (9226a12
). Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
That'll do the trick :) For the record, you can achieve that using
git rebase
.@all-contributors add @ApprenticeofEnder for code
I did actually try that, but I think I messed something up and I couldn't actually rebase to the point I wanted to. I'll have to give it another try later.
@ApprenticeofEnder
I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.
@ApprenticeofEnder already contributed before to code
Fixes #400.
Summary of changes:
NOTE:
pytest-asyncio==0.21.1
caused an error that resulted inAttributeError: 'FixtureDef' object has no attribute 'unittest'
. According to the associated Github Issue, bumping to 0.21.2 (and, subsequently, pinning thepytest
andpytest-cov
versions) fixed the issue.