fieldOfView / Cura-ArcWelderPlugin

Cura plugin which wraps ArcWelderLib to convert multiple G0/G1 moves to G2/G3 arcs.
GNU Affero General Public License v3.0
69 stars 4 forks source link

Printer profile settings not registering #17

Open Asterchades opened 3 years ago

Asterchades commented 3 years ago

I've created a complete custom printer profile for my use which defines a number of settings that I use globally - many of which are formulaic, which is why I don't just use the internal Cura print profile feature. Two of the options I set in this profile are "arcwelder_enable" (true) and "arcwelder_g90_influences_extruder" (also true). However, neither of these settings are "taking" when using the base printer profile, instead reverting to their default values (false for both). This is the same whether I reassign the "value" or "default_value", or both, in the printer profile.

All other options are functioning as I have specified.

The specific declarations I use are:

                "arcwelder_enable": { "value": true },
                "arcwelder_g90_influences_extruder": { "value": true }

No trailing comma as that is the final entry in the profile.

In case it is relevant, I am using SmartAvionics' master builds of Cura, last updated April 20th (just after the 4.9 release). Plugin is v3.5.1 from the Cura Marketplace.

fieldOfView commented 3 years ago

Specifying values in the .def.json file is going to be hard to impossible to support in this plugin, because the .def.json is loaded and parsed before the plugin adds its own settings to Cura. In doing so it replaces the settings you made.

Just in case though, could you zip up your .def.json files so I can see exactly how you are trying to do this?

Asterchades commented 3 years ago

Thalyn_FDM.def.zip

Pretty much exactly as stated. I use two profiles so I can separate out the things that I don't want across all Cura installs (like disabling Wipe for Arachne at present) or printers.

fieldOfView commented 3 years ago

I'm considering this as "not a bug", but I'll keep the issue open as an "enhancement"/feature request. I never intended the plugin values to be set in the printer definition (.def.json). You can set them in profiles (.inst.cfg) and even in xml material profiles if you wish.

Asterchades commented 3 years ago

Sounds good to me.