search

fieldOfView / Cura-CustomJobPrefix

A Cura plugin that lets the user set a custom print job prefix
GNU Affero General Public License v3.0
24 stars 5 forks source link

Critical error in cura-git-4.8.0.r350.gfa4d1ba1fb #24

Closed ustsv closed 3 years ago

ustsv commented 3 years ago

After this commit in cura git, critical error:

SHA-1: fa4d1ba1fbe4685dbab21825c7fa0bcbdc889b36, &Номер ревизии ветви: 5022

Don't strip accents from job name

No idea why this was there in the first place. Our archeology attempts couldn't find out as to why it was introduced. We suspect an issue with other Qt versions.

At least now ロボット.stl will not be mangled into ロホット.gcode upon saving (and german bears into bars)

Traceback (most recent call last): File "C:/Users/name/AppData/Roaming/cura/4.8/plugins/CustomJobPrefix/CustomJobPrefix/PrintInformationPatches.py", line 120, in _triggerJobNameUpdate self._updateJobName() File "C:/Users/name/AppData/Roaming/cura/4.8/plugins/CustomJobPrefix/CustomJobPrefix/PrintInformationPatches.py", line 129, in _updateJobName base_name = self._print_information._stripAccents(self._print_information._base_name) AttributeError: 'PrintInformation' object has no attribute '_stripAccents'

fieldOfView commented 3 years ago

I would not recommend running Cura master, for exactly reasons like this. I already predicted this breakage when I saw the commit here: https://github.com/Ultimaker/Cura/commit/fa4d1ba1fbe4685dbab21825c7fa0bcbdc889b36 (see the comments)

I'll fix it.

fieldOfView commented 3 years ago

Should be fixed in 95e5bbf. I'll leave this issue open until a version containing this fix is available in the Marketplace.