search

fieldOfView / Cura-LinearAdvanceSettingPlugin

A Cura plugin that adds a Linear Advance Factor setting for use in start gcode snippets
GNU Affero General Public License v3.0
35 stars 15 forks source link

Update Readme to reflect new Klipper syntax #37

Closed soxhi8 closed 1 year ago

soxhi8 commented 2 years ago

Klipper received a breaking change on setting default parameters lately, so the macro needs to be updated. https://github.com/Klipper3d/klipper/issues/4864

fieldOfView commented 2 years ago

Does this need a note about which versions of Klipper need which syntax, or does the new syntax work for all versions?

soxhi8 commented 2 years ago

I will check compatibility for older versions and report back once I know more.

jjgraphix commented 2 years ago

I can confirm the proposed syntax should have no issues in any documented Klipper version that supports macros. Anything prior to this wouldn't be relevant anyway.

If it's helpful, to avoid macros and resolve other compatibility issues like multiple extruders, I remixed your work into an unofficial PressureAdvanceSettingPlugin for Klipper only. I've continued development for my own curiosity but some of my changes might help if you decide to focus on Klipper support. It may not be worth it but perhaps a Klipper Firmware Support sub-setting would be a workaround to getting this fully compatible, unless you convince the devs to add a klipper g-code flavor :).

fieldOfView commented 1 year ago

I don't know why I never merged this, but better late than never, I guess.

soxhi8 commented 1 year ago

I don't know why I never merged this, but better late than never, I guess.

You were likely waiting for more confirmation on compatibility on older versions of Klipper, which I did not get around to testing in detail. But as jigraphix said, it should not be an issue. Thanks for merging!