fieldOfView / Cura-OctoPrintPlugin

Cura plugin which enables printing directly to OctoPrint and monitoring the process
GNU Affero General Public License v3.0
484 stars 74 forks source link

timelapse option #178

Closed alexandrosmagos closed 4 years ago

alexandrosmagos commented 4 years ago

Whenever I start a print from the octoprint's UI, timelapse recording automatically starts, but whenever I start a print from Cura, it doesn't start a timelapse.

Don't yet not if this is implimented or not, or if there's a setting for this is octoprint's settings, but couldn't find anything. Love literally everything about this plugin but this is the one thing that's missing imo.

fieldOfView commented 4 years ago

I'll see what is going on, and if there is anything I can do about it.

alexandrosmagos commented 4 years ago

Started using octolapse plugin on octoprint, and whenever I start now a print from Cura that starts as well with flawless results, so sort of, it's solved.

fieldOfView commented 4 years ago

I hope you don't mind if I keep this issue open for a while longer, until I have time to see if there is anything I can do to fix the problem for the standard timelapse functionality.

fieldOfView commented 4 years ago

I have looked in to it, and came to the conclusion that it should work, and if it does not work then it should be fixed in OctoPrint.

OctoPrint starts the timelapse when a print is started here: https://github.com/OctoPrint/OctoPrint/blob/6232a04e52fbf09a8b912590718764fccc3598ba/src/octoprint/timelapse.py#L464 That method is triggered by the Events.PRINT_STARTED event. If the timelapse does not start when the gcode file is uploaded through the API, then that means that that event does not fire (?!).