search

fieldOfView / Cura-OctoPrintPlugin

Cura plugin which enables printing directly to OctoPrint and monitoring the process
GNU Affero General Public License v3.0
493 stars 74 forks source link

i18n added #224

Closed Elkin-Vasily closed 3 years ago

Elkin-Vasily commented 3 years ago

Multilanguage support added; ru_RU locale added.

I had added only ru_RU locale but you can find how to add others here: https://github.com/Jeredian/mks-wifi-plugin/wiki/Translation

Elkin-Vasily commented 3 years ago

This may be helpful to: https://github.com/Jeredian/mks-wifi-plugin/wiki/Cura-plugin-translation-guide

Elkin-Vasily commented 3 years ago

I had not mention: there is no need to create English locale (or any others) to merge this pull request. If current Cura locale would not found in plugins i18n directory English (default) translation will be shown.

Elkin-Vasily commented 3 years ago

And more: I have tested compiled .mo file on Windows and macOS and it works Ok on both. Unfortunately I have no Linux to test with, but I think it will be Ok too.

fieldOfView commented 3 years ago

Thanks for the PR. The reason I have not merged it yet is that I have not yet had time to look in to how to keep the .pot file continuously up to date. I do mean to merge it.

fieldOfView commented 3 years ago

Thank you very much for your contribution.

fieldOfView commented 2 years ago

@Elkin-Vasily, I have updated the .pot in 1637bd23b71d07de331751404e84a17e7914c4c4, and wanted to check in with you to see if I did it correctly (and updating the .pot like this keeps your translation mostly intact).

There has been some restructuring of the "Manual instance" dialog.

Elkin-Vasily commented 2 years ago

Made new PR #252 for this.

The translation was mostly intact (2 strings was deleted, 1 added).