Closed earthicko closed 3 years ago
ngrok.install_ngrok()
should already be called when installing the plugin. Could you check/share your plugin_pluginmanager_console.log?
Here it is:
2020-11-16 18:54:34,673 /home/pi/oprint/bin/python -m pip --disable-pip-version-check install file:///tmp/tmpkapd4lg/OctoPrint-ngrok-master.zip --no-cache-dir 2020-11-16 18:54:37,096 > Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple 2020-11-16 18:54:37,097 > Processing /tmp/tmpkapd4lg/OctoPrint-ngrok-master.zip 2020-11-16 18:54:37,097 > Requirement already satisfied: OctoPrint in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint-ngrok==0.3.1) (1.4.2) 2020-11-16 18:54:40,855 > Collecting pyngrok>=4.1.3 2020-11-16 18:54:40,855 > Downloading https://www.piwheels.org/simple/pyngrok/pyngrok-5.0.0-py3-none-any.whl (21 kB) 2020-11-16 18:54:40,856 > Requirement already satisfied: Flask-Login<0.6,>=0.5 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.5.0) 2020-11-16 18:54:40,856 > Requirement already satisfied: itsdangerous<2,>=1.1.0 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.1.0) 2020-11-16 18:54:40,856 > Requirement already satisfied: flask<2,>=1.1.2 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.1.2) 2020-11-16 18:54:40,856 > Requirement already satisfied: pylru<2,>=1.2 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.2.0) 2020-11-16 18:54:40,856 > Requirement already satisfied: werkzeug<2,>=1.0.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.0.1) 2020-11-16 18:54:40,856 > Requirement already satisfied: sarge==0.1.5post0 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.1.5.post0) 2020-11-16 18:54:40,856 > Requirement already satisfied: psutil<6,>=5.7 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (5.7.2) 2020-11-16 18:54:40,856 > Requirement already satisfied: future<1,>=0.18.2 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.18.2) 2020-11-16 18:54:40,857 > Requirement already satisfied: netaddr<1,>=0.7.19 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.8.0) 2020-11-16 18:54:40,857 > Requirement already satisfied: Jinja2<3,>=2.11.2 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (2.11.2) 2020-11-16 18:54:40,857 > Requirement already satisfied: markdown<3.2,>=3.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (3.1.1) 2020-11-16 18:54:40,857 > Requirement already satisfied: OctoPrint-FileCheck>=2020.07.06 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (2020.8.7) 2020-11-16 18:54:40,857 > Requirement already satisfied: Flask-Assets<3,>=2.0 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (2.0) 2020-11-16 18:54:40,857 > Requirement already satisfied: emoji<1,>=0.5.4 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.6.0) 2020-11-16 18:54:40,857 > Requirement already satisfied: feedparser<6,>=5.2.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (5.2.1) 2020-11-16 18:54:40,857 > Requirement already satisfied: markupsafe<2.0,>=1.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.1.1) 2020-11-16 18:54:40,858 > Requirement already satisfied: regex!=2018.11.6 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (2020.9.27) 2020-11-16 18:54:40,858 > Requirement already satisfied: wrapt<2,>=1.12.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.12.1) 2020-11-16 18:54:40,858 > Requirement already satisfied: pyserial<4,>=3.4 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (3.4) 2020-11-16 18:54:40,858 > Requirement already satisfied: PyYAML<6,>=5.3.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (5.3.1) 2020-11-16 18:54:40,858 > Requirement already satisfied: requests<3,>=2.23.0 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (2.24.0) 2020-11-16 18:54:40,858 > Requirement already satisfied: frozendict<2,>=1.2 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.2) 2020-11-16 18:54:40,858 > Requirement already satisfied: unidecode<0.05,>=0.04.14 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.4.21) 2020-11-16 18:54:40,858 > Requirement already satisfied: filetype<2,>=1.0.7 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.0.7) 2020-11-16 18:54:40,859 > Requirement already satisfied: cachelib<1,>=0.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.1.1) 2020-11-16 18:54:40,859 > Requirement already satisfied: websocket-client<1,>=0.57 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.57.0) 2020-11-16 18:54:40,859 > Requirement already satisfied: pkginfo<2,>=1.5.0.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.5.0.1) 2020-11-16 18:54:40,859 > Requirement already satisfied: blinker<2,>=1.4 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.4) 2020-11-16 18:54:40,859 > Requirement already satisfied: watchdog<1,>=0.10.2 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.10.3) 2020-11-16 18:54:40,859 > Requirement already satisfied: semantic-version<3,>=2.8.5 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (2.8.5) 2020-11-16 18:54:40,859 > Requirement already satisfied: tornado==5.1.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (5.1.1) 2020-11-16 18:54:40,859 > Requirement already satisfied: netifaces<1,>=0.10.9 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.10.9) 2020-11-16 18:54:40,860 > Requirement already satisfied: sentry-sdk<1,>=0.15.1 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (0.18.0) 2020-11-16 18:54:40,860 > Requirement already satisfied: OctoPrint-FirmwareCheck>=2020.06.22 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (2020.9.23) 2020-11-16 18:54:40,860 > Requirement already satisfied: Click<8,>=7.1.2 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (7.1.2) 2020-11-16 18:54:40,860 > Requirement already satisfied: rsa==4.0 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (4.0) 2020-11-16 18:54:40,860 > Requirement already satisfied: Flask-Babel<2,>=1.0 in /home/pi/oprint/lib/python3.7/site-packages (from OctoPrint->OctoPrint-ngrok==0.3.1) (1.0.0) 2020-11-16 18:54:40,860 > Requirement already satisfied: setuptools>=36 in /home/pi/oprint/lib/python3.7/site-packages (from markdown<3.2,>=3.1->OctoPrint->OctoPrint-ngrok==0.3.1) (50.3.0) 2020-11-16 18:54:40,860 > Requirement already satisfied: webassets>=2.0 in /home/pi/oprint/lib/python3.7/site-packages (from Flask-Assets<3,>=2.0->OctoPrint->OctoPrint-ngrok==0.3.1) (2.0) 2020-11-16 18:54:40,860 > Requirement already satisfied: certifi>=2017.4.17 in /home/pi/oprint/lib/python3.7/site-packages (from requests<3,>=2.23.0->OctoPrint->OctoPrint-ngrok==0.3.1) (2020.6.20) 2020-11-16 18:54:40,861 > Requirement already satisfied: idna<3,>=2.5 in /home/pi/oprint/lib/python3.7/site-packages (from requests<3,>=2.23.0->OctoPrint->OctoPrint-ngrok==0.3.1) (2.10) 2020-11-16 18:54:40,861 > Requirement already satisfied: chardet<4,>=3.0.2 in /home/pi/oprint/lib/python3.7/site-packages (from requests<3,>=2.23.0->OctoPrint->OctoPrint-ngrok==0.3.1) (3.0.4) 2020-11-16 18:54:40,861 > Requirement already satisfied: urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1 in /home/pi/oprint/lib/python3.7/site-packages (from requests<3,>=2.23.0->OctoPrint->OctoPrint-ngrok==0.3.1) (1.25.10) 2020-11-16 18:54:40,861 > Requirement already satisfied: six in /home/pi/oprint/lib/python3.7/site-packages (from websocket-client<1,>=0.57->OctoPrint->OctoPrint-ngrok==0.3.1) (1.15.0) 2020-11-16 18:54:40,861 > Requirement already satisfied: pathtools>=0.1.1 in /home/pi/oprint/lib/python3.7/site-packages (from watchdog<1,>=0.10.2->OctoPrint->OctoPrint-ngrok==0.3.1) (0.1.2) 2020-11-16 18:54:40,861 > Requirement already satisfied: pyasn1>=0.1.3 in /home/pi/oprint/lib/python3.7/site-packages (from rsa==4.0->OctoPrint->OctoPrint-ngrok==0.3.1) (0.4.8) 2020-11-16 18:54:40,861 > Requirement already satisfied: pytz in /home/pi/oprint/lib/python3.7/site-packages (from Flask-Babel<2,>=1.0->OctoPrint->OctoPrint-ngrok==0.3.1) (2020.1) 2020-11-16 18:54:40,861 > Requirement already satisfied: Babel>=2.3 in /home/pi/oprint/lib/python3.7/site-packages (from Flask-Babel<2,>=1.0->OctoPrint->OctoPrint-ngrok==0.3.1) (2.8.0) 2020-11-16 18:54:40,862 > Building wheels for collected packages: OctoPrint-ngrok 2020-11-16 18:54:40,862 > Building wheel for OctoPrint-ngrok (setup.py): started 2020-11-16 18:54:42,198 > Building wheel for OctoPrint-ngrok (setup.py): finished with status 'done' 2020-11-16 18:54:42,198 > Created wheel for OctoPrint-ngrok: filename=OctoPrint_ngrok-0.3.1-py3-none-any.whl size=20935 sha256=4bf4856efd2ef72579e40b1a978dd67b8a915e7a4eb8efa259890a7bdf382c12 2020-11-16 18:54:42,198 > Stored in directory: /tmp/pip-ephem-wheel-cache-ngd3a42p/wheels/a3/c4/a1/6390dc6a995e165c0d276071a2b7fc3780e741f2364ae9587c 2020-11-16 18:54:42,198 > Successfully built OctoPrint-ngrok 2020-11-16 18:54:42,198 > Installing collected packages: pyngrok, OctoPrint-ngrok 2020-11-16 18:54:42,198 > Successfully installed OctoPrint-ngrok-0.3.1 pyngrok-5.0.0
It's rather strange cause I can't find any error or warning logs. I've set octoprint's logging level to 'DEBUG'.
It turns out the ngrok binary should automatically be downloaded and installed the first time ngrok.connect()
is called, so any errors would not show up in the plugin installer log. So the bug at hand is that ngrok.connect()
is not the first call to the binary that happens (ngrok.getVersion()
is).
Fixed in version 0.3.2. Thanks for the report!
Thank you for your fast support! I appreciate your activeness and commitment.
There seems to be a problem when loading the plugin initially. Here's the error log below:
Adding
ngrok.install_ngrok()
on line 35 of./__init__.py
solved the problem, though I'm not sure this is a valid solution.