search

fieldOfView / OctoPrint-ngrok

An OctoPrint Plugin that provides remote access using ngrok
GNU Affero General Public License v3.0
15 stars 8 forks source link

Plug-in not showing in Octoprint #25

Closed soundforascene closed 3 years ago

soundforascene commented 3 years ago

Since updating to 0.3.2 it does not seem to be functioning. I have gone through the logs and and found this.

| OctoPrint-ngrok (0.3.2) = /home/pi/oprint/local/lib/python2.7/site-packages/octoprint_ngrok 2020-11-16 14:12:24,490 - octoprint.plugins.pluginmanager - INFO - The plugin was installed successfully: OctoPrint-ngrok, version 0.3.2 2020-11-16 14:12:24,795 - octoprint.plugins.tracking - INFO - Sent tracking event install_plugin, payload: {'plugin_version': '0.3.2', 'plugin': 'ngrok'} 2020-11-16 14:12:34,615 - octoprint.plugin.core - ERROR - Invalid syntax in /home/pi/oprint/local/lib/python2.7/site-packages/octoprint_ngrok/init.py for plugin ngrok File "/home/pi/oprint/local/lib/python2.7/site-packages/octoprint_ngrok/init.py", line 36 if ngrok.version >= '5.0.0'

I am not entirely sure if this is due to the update or my own wrong doing. Hope it helps.

jneilliii commented 3 years ago

@fieldOfView it looks like you're missing a colon in your if statement...

https://github.com/fieldOfView/OctoPrint-ngrok/blob/65c58e0839c0e9cdf1a83ad72a7c4a42756af47e/octoprint_ngrok/__init__.py#L36

fieldOfView commented 3 years ago

it looks like you're missing a colon in your if statement...

It certainly looks that way... 🤦‍♂️

fieldOfView commented 3 years ago

Fixed in 0.3.3