feature/qrcode - Githubissues

fieldOfView / OctoPrint-ngrok

An OctoPrint Plugin that provides remote access using ngrok

GNU Affero General Public License v3.0

15 stars 8 forks source link

feature/qrcode #28

Closed jneilliii closed 3 years ago

jneilliii commented 3 years ago

add qr code support for the navbar dropdown as configurable option in settings as mentioned in community forum.

jneilliii commented 3 years ago

need to do some additional testing. looks like the qr code may not be updating properly.

fieldOfView commented 3 years ago

Cool, thanks for the PR. Two remarks sofar:

I would like some margins around the QR code. I think it is even officially required to detect the QR code, but honestly it is just because of aesthetics for me.
Doesn't OctoPrint ship with the required code to generate QR codes?

jneilliii commented 3 years ago

oh good point @fieldOfView it does have QR codes inside the API stuff. I'll look at that and adjust accordingly. I figured out the update issue and will also fix that.

jneilliii commented 3 years ago

you're totally right, and it's actually part of the access control plugin, and seems to be the same module library. I'll remove it from the PR and see how it goes.

jneilliii commented 3 years ago

should be ready to test Aldo.

fieldOfView commented 3 years ago

Thanks!