OAuth and UI tweaks - Githubissues

fieldOfView / OctoPrint-ngrok

An OctoPrint Plugin that provides remote access using ngrok

GNU Affero General Public License v3.0

15 stars 8 forks source link

OAuth and UI tweaks #37

Open jneilliii opened 9 months ago

jneilliii commented 9 months ago

Added options for using OAuth
Updated inline help for custom domains since free members get a static one included, #34
Updated ngrok dashboard links

fieldOfView commented 9 months ago

This looks great, thanks. Can I trust you on your bright blue eyes that this works? I don't have much time to test this at the moment. I would say that your testing is better than mine.

jneilliii commented 9 months ago

I can tell you I've been using it with one minor issue. Not sure if it's related to newer versions of OctoPrint, or the latest rc I'm testing but if Use these credentials to log in to OctoPrint. is enabled after logging in remotely it killed the running service. However, I think that was happening prior to my changes because I attempted to access this test device a week or two ago from work and it did the same with basic authentication.

jneilliii commented 9 months ago

Just confirmed, downgrading the plugin to the latest released version and enabling that option does kill OctoPrint., so unrelated to this change.

paynerc commented 4 months ago

I have been testing these changes this morning and would 👍🏻 this for getting merged into this plugin for release.

@jneilliii thanks for adding this! The continual re-auth for basic auth was driving me crazy.