allow use of custom domains

fieldOfView / OctoPrint-ngrok

An OctoPrint Plugin that provides remote access using ngrok

GNU Affero General Public License v3.0

15 stars 8 forks source link

allow use of custom domains #4

Closed madmaximus00 closed 3 years ago

madmaximus00 commented 4 years ago

It would be awesome to use a completely custom domain, or at least the option to.

fieldOfView commented 4 years ago

I will certainly add this option in a future version; it is something that ngrok supports, but only for paid accounts (from $5 per month). Two caveats:

I would like to keep the configuration form compact, without too many options a user may not (be able to) use. Some rearranging may be in order.
I'll have to look in to how this works with SSL certificates; will they register a certificate for you so you automatically have working HTTPS?

fieldOfView commented 4 years ago

Are you aware that custom domains are only available on business and pro accounts? They also require a bit of external configuration on your domains, which this plugin cannot do for you, and the ssl certificate will be broken.

madmaximus00 commented 4 years ago

I have done the first two, just looking into the ssl certificate part.

your two caveats makes sense though.

fieldOfView commented 4 years ago

I have implemented the functionality here: https://github.com/fieldOfView/OctoPrint-ngrok/commit/e1146a856dd8ce7bcf1b7244eb7f98fd50d0eb33. But since I don't have a pro account I can't test it.

madmaximus00 commented 4 years ago

I'll test it out as soon as its released.

fieldOfView commented 3 years ago

0.2.0 is now available