Use versioned target population

fielded / angular-nav-thresholds

DEPRECATED Angular NAV module for calculating thresholds

Apache License 2.0

0 stars 0 forks source link

Use versioned target population #22

Closed patriciagarcia closed 7 years ago

patriciagarcia commented 7 years ago

Connects #20

Updates the service to use the new versioned target population field
Makes sure that if no version is provided for any of the factors, version 1 is used by default

patriciagarcia commented 7 years ago

Semantic release failing, it was working for me locally but I made the mistake of removing my node_modules folder to be able to replicate the error. Now I can see the error but I have no idea how to fix it ;-).

Any clue https://travis-ci.org/fielded/angular-nav-thresholds?

patriciagarcia commented 7 years ago

Uh, actually what fails is rollup -c and it creates a weir file called -c that contains undefined

> npm run -s build && karma start
resolve failed:  { [Error: Cannot find module 'babel-runtime'] code: 'MODULE_NOT_FOUND' } babel-runtime
resolve failed:  { [Error: Cannot find module '@semantic-release'] code: 'MODULE_NOT_FOUND' } @semantic-release
Aborting commit due to empty commit message.

tlvince commented 7 years ago

Pinning didn't work, but can reproduce locally.

tlvince commented 7 years ago

Error is due to some publishing mess in https://github.com/rollup/babel-preset-es2015-rollup. Either way, that package is deprecated. Will push a fix direct to the branch here.

patriciagarcia commented 7 years ago

@tlvince, updated to take into account the proper target population field naming and to make it backwards compatible with non versioned TPs