search

fieldenms / tg

Trident Genesis
MIT License
14 stars 7 forks source link

Money Type Enhancement #26

Open 01es opened 10 years ago

01es commented 10 years ago

Type Money need to be enhanced in order to support construction of ex tax (i.e. ex GST, ex VAT) instances. Also, need to use type BigDecimal for representing a tax rate due to the fact that some countries use fractional tax rates (e.g. in UK until 2011 VAT was 17.5%).

elvin-fms commented 9 years ago

I have just noticed that Money uses plus() and minus() to add and subtract another Money - it would be more consistent if Money used add() and subtract() for consistency with BigDecimal, as there are often used together and BigDecimal.plus() has a different meaning compared to BigDecimal.add().