fieldrndservices / libssh2-labview

A LabVIEW library for SSH client support via libssh2
Apache License 2.0
21 stars 2 forks source link

Change the Channel Create SCP Receive instance to include creation and destruction of the File Info object #19

Closed volks73 closed 4 years ago

volks73 commented 4 years ago

The Channel Create SCP Receive instance is kind of awkward to use. A File Info object must be created the Channel first, then the remote file size is obtained and then the File Info object is destroyed. See:

Current

It just looks messy. I think this was done originally because the polymorphic selector was hidden, so the instance controls could not be similar to another instance for the automatic selection to work properly. Now that the selector is visible by default, I think this need is removed and the File Info creation, usage, and destruction can be wrapped into the SCP Receive variant.

However, there are a couple of concerns:

volks73 commented 4 years ago

As of 588dbb130c47bb3f6ea07ef397f77f394e617d8c, the Create SCP Receive VI uses an internal File Info object and returns all of the file information as a cluster. This greatly simplifies creating a SCP download-like VI.