search

fieldrndservices / libssh2-labview

A LabVIEW library for SSH client support via libssh2
Apache License 2.0
21 stars 2 forks source link

Make port type configurable #43

Closed Volinger closed 2 years ago

Volinger commented 2 years ago

Hello,

would it be possible to change Session/connect.vi VI, or add some other with the same functionality, which would allow to use other port for SSH than 22? Currently it is hardcoded as I can see and I dont see any way in the toolkit, which would allow me to select the SSH port. Here is what I suggest: Before: image After: image

volks73 commented 2 years ago

Looks good to me and makes perfect sense. I would add it to the connector pane of the VI at the bottom between the Error In and Error Out terminals and make it optional with a default of 22, which should be next to the Timeout terminal.

Volinger commented 2 years ago

Thank you, shall I update it or will you do it please? I tried to, since you assigned the issue to me, but I think I need some rights to the repository to push the code and create and create a pull request if I am not mistaken : )

volks73 commented 2 years ago

I have gone ahead and made the change to the Connect VI. This should be available as of 18100aeeca013c3a8bc970b98ff88c68b69ef333.

I am closing this issue, but it may be while before I create a new release. However, this change is available from the source code by cloning this repository (git clone https://github.com/fieldrndservices/libssh2-labview.git). You should be able to clone the repository. If you cannot, then please let me know.

For future reference, the conventional process for contributing code would be fork this repository within GitHub, clone your forked repository within your user account onto your local development machine, modify the code, commit changes, push changes to your forked repository, and then submit a Pull Request. I think you may have run into some permissions issue because you were trying to submit PR directly from a clone of this repository instead of a fork. Note, a GitHub "fork" is not necessarily the same thing as a "hard" fork. PR submission to this repository does require write access from the maintainer.