fiendish / aardwolfclientpackage

Get the Aardwolf MUSHclient Package installer at
https://fiendish.github.io/aardwolfclientpackage/
Other
86 stars 33 forks source link

Add map_find_query function to aard_GMCP_mapper.xml. #288

Closed tim-chaplin closed 4 years ago

tim-chaplin commented 4 years ago

This allows users and other plugins to call mapper.find() with arbitrary SQL queries.

I also refactored a couple of functions to use map_find_query(), and removed a couple of unused args in aardmapper.lua.

tim-chaplin commented 4 years ago

This is my first time using GitHub, please let me know if I'm doing something wrong.

fiendish commented 4 years ago

looks ok, but what's it for?

removed a couple of unused args

Good eye. I appreciate it.

tim-chaplin commented 4 years ago

It's so I (and others) can make aliases to do various types of room searches without having to add each one to the aardwolf_gmcp_mapper plugin. For example so far I've found useful:

fiendish commented 4 years ago

"mapper find" except matching a room name exactly

Can already do this by putting quotation marks around your search string. It's handled by: https://github.com/fiendish/aardwolfclientpackage/blob/f3d7a146771b5283a44ad17a771ac13774330216/MUSHclient/worlds/plugins/aard_GMCP_mapper.xml#L3848-L3852

fiendish commented 4 years ago

search for all reachable maze rooms in the current area to easily get to the start of a maze

What do you do if there's more than one reachable maze room or more than one reachable maze section?

tim-chaplin commented 4 years ago

Can already do this by putting quotation marks around your search string. It's handled by:

Ah, good to know.

What do you do if there's more than one reachable maze room or more than one reachable maze section?

I still have to manually click the right room in that case but it's a lot more convenient than trying to remember the name or walk there by hand.