search

fiendish / aardwolfclientpackage

Get the Aardwolf MUSHclient Package installer at
https://fiendish.github.io/aardwolfclientpackage/
Other
86 stars 33 forks source link

Update aard_GMCP_mapper.xml #329

Closed AardCrowley closed 7 months ago

AardCrowley commented 7 months ago

Added mapper cexits purge area

AardCrowley commented 7 months ago

So, turned out I wasn't updated to the current snapshot so the GMCP mapper file I had was grossly out of date by a couple of snapshot versions. I fixed it on my end now, though, and added the new command.

AardCrowley commented 7 months ago

Right. The development branch has the StopEvaluatingTriggers(), whereas the Master Branch has StopEvaluatingTriggers(true). So, the change came because I took what's in the Master Branch (which I imagine one should), and pushed to the Development branch.

Though if there are changes in the Dev branch that aren't ready yet, should that be where we push the requests?

AardCrowley commented 7 months ago

Side note: I say 'imagine one should' only because we don't really have access to the development branch in general, so changes made to plugins are always done with whatever is in the latest snapshot in the main branch.

fiendish commented 7 months ago

I took what's in the Master Branch (which I imagine one should), and pushed to the Development branch.

Ok, but please use what's in the development branch. :)

we don't really have access to the development branch in general

Yes you do. :)

AardCrowley commented 7 months ago

So, the l got changed to a 1 because I tend to type out the code rather than just copy/paste in most cases, and not having glasses on when I did so last time made me think the ls were 1s.

Regardless, what I did now was copy what was in your development branch, then made the changes in my own development branch, so the two should match with the exception of what I've added.

fiendish commented 7 months ago

thank you!