Various improvements (options, server, re-using image)

udondan commented 5 years ago

Great action! I had to do some changes to make it work for me.

Sorry for not committing separate PR's. Customized it until it worked for me. 😃

Added pdfOptions input, so user can forward custom optons.
Replaced the custom written server with serve-static. The original server only served a single HTML page. I needed support for relative files: CSS, JS and custom fonts.
Replaced the custom base Docker image with buildkite/puppeteer. This one seems maintained, popular and only is 286MB in size. I think yours was 479MB.
Removed some code that did not make sense to me (e.g. legacyOptions). Wasn't passed from main.js.
Removed the includeAssets() function. That seemd very custom to a specific setup. Now with the new http server, serving all files in the root, css files included in the HTML document (print styles) can be used

Let me know if anything conflicts with your setup. I tested your example.html file and it renders nicely.

fifsky commented 5 years ago

Great change, Thank you

udondan commented 5 years ago

thanks for merging :)

bjornamr commented 3 years ago

@udondan

How is it possible to use custom css & fonts? Do you have an example of that?

udondan commented 3 years ago

@bjornamr There's actually nothing special about it. I just reference CSS files which contain font declarations.

I'm using it to render my personal vita, source is here: https://github.com/udondan/www.udondan.com It makes use of Font Awesome. Result can be seen here https://www.udondan.com/ - PDF can be downloaded by clicking the red button on the right side.

fifsky / html-to-pdf-action