search

fifty-six / HollowKnight.RandomizedPantheons

Randomized pantheons
GNU General Public License v3.0
0 stars 3 forks source link

Potentially duplicate or missing bosses #6

Open Clazex opened 1 year ago

Clazex commented 1 year ago

The currently used shuffling may cause some bosses to be missing or duplicate for its possibility of potential collision.

Proof: Randomized P5 hitless by TBA, Oro & Mato 1st at start and 2nd at 03:25, no Sly.

Suggestion: Use Fisher–Yates shuffle.

Clazex commented 1 year ago

btw GG_Spa is a safe first scene if you correctly set the target scene in fsm.

fifty-six commented 1 year ago

OrderBy with rand.Next isn't great performance wise but OrderBy is a stable sort so it won't remove duplicates or anything like that. The issue is probably just from the first scene. I'll take a look when I get time.