search

fifty-six / Scarab

An installer for Hollow Knight mods written in Avalonia.
GNU General Public License v3.0
615 stars 163 forks source link

Update when its different version instead of lower #115

Closed TheMulhima closed 1 year ago

TheMulhima commented 1 year ago

reasoning: https://github.com/hk-modding/modlinks/pull/763

fifty-six commented 1 year ago

I dislike this from a versioning point of view tbh. If someone releases something broken I'd prefer for them to fix it and bump the version or something honestly. I believe other things which handle packages/deps/etc. do this similarly? I could still be convinced otherwise though

TheMulhima commented 1 year ago

Well what happened in this case (linked above) was that the broken mod (failed to init for some reason) was added on 30 October, the author went offline and returned on 30th November to finally update it. In between that month they didn't push a new fixed release for whatever reason and we couldn't really do anything about it other than revert to old working version but that didn't fix anything for the people who already had the mod as scarab didn't prompt to update the mod.

fifty-six commented 1 year ago

I mean you can bump the version while providing the old mod if really needed, though I'd be interested in additional feedback if several other people also feel this is necessary.

SFGrenade commented 1 year ago

from a versioning point of view, yes, that would not be great, but.

for version control, one could also allow users to downdate their version, in case of actual package managers one has to specify the version and force the "up"date to a lower version.

so i could see it being allowed, but only after the user explicitly pressed a downgrade button or a setting that has to be enabled or something

fifty-six commented 1 year ago

I'm closing this, at least for now. If we're gonna do this it'd be a downgrade button and all.