fifty-six / Scarab

An installer for Hollow Knight mods written in Avalonia.
GNU General Public License v3.0
592 stars 160 forks source link

Modded is no longer identified as Vanilla #124

Closed ghost closed 1 year ago

ghost commented 1 year ago

Fix #67

fifty-six commented 1 year ago

I don't want to load the assembly to check if it's vanilla, that was a fairly explicit choice in the design. Having Mono.Cecil as a dependency is about 6 layers of overkill and loading assemblies at all is something I've been very much avoiding.

ghost commented 1 year ago

Is there anything fatal about this?

fifty-six commented 1 year ago

wdym fatal? It's just something I didn't want to put in the program. Anyone who's modding their assembly beforehand should in theory be capable enough of reverting to vanilla before using the installer I would hope. If this feature is something actually needed, I prefer the SHA1 approach for the vanilla assembly at this point given that they probably are done with updates, though last time I said that they proceeded to update it again anyways

ghost commented 1 year ago

I know