fifty-six / Scarab

An installer for Hollow Knight mods written in Avalonia.
GNU General Public License v3.0
592 stars 160 forks source link

Mouse position stops keyboard/controller from reaching some mod options #151

Closed mirror176 closed 1 year ago

mirror176 commented 1 year ago

Scarab Version

1.31.0.0

Hollow Knight Version

1.5.78.11833

Steps to Reproduce

Load game > Options > Mods > Hallownext Voicalized Options. Place mouse at 'Dream Nail'. Keyboard/controller moving up and down not functional until setting is turned off.

Set Autoscroll=off and Dream Nail Dialogue=on and place mouse at 'Scroll Lock'

Set Autoscroll=off and Dream Nail Dialogue=off, move mouse to a stated location below and toggle Dream Nail Dialogue=on.

Inside of 'Change Volume', HK Vocals Volume and Go to Hallownest Vocalized settings seem inaccessible from keyboard/controller with menu wrapping past them. Mouse can place focus there and keyboard/controller can edit setting but leaving it jumps two options away in whatever direction is pressed even if the next nonskipped option was 1 away in that direction.

Expected Behaviour

Menu should wrap like it does with Autoscroll=on and Dream Nail Dialogue=off; suspect issue with how dynamically collapsing menus are functioning. All options should be reachable in 'Change Volume'; probably mislabeling where next/previous menu item is to navigate to or in tracking which one it is on within that list.

Actual Behaviour

Described in steps to reproduce. I found this by only touching controller after freshly installing the mod and started seeing buggy menu interaction as I explored the new options though I think I was first in the menu after passing the game intro on a savefile.

Logs

Game is not on this computer but will obtain logs if there are any issues reproducing it.

fifty-six commented 1 year ago

This is a great bug report so thank you for that, but it's also not a Scarab issue. If you don't mind, I'd say to report this to the Hallownest Vocalized repository, which should be in its description in Scarab. It might also be an API thing, though they'd know better than me given they could've added custom stuff - in which case they can file an issue for that.

mirror176 commented 1 year ago

My apologies for posting to the wrong repository; I will get this over to theirs. Keep up the good work and have a great day.