fifty-six / Scarab

An installer for Hollow Knight mods written in Avalonia.
GNU General Public License v3.0
592 stars 160 forks source link

prevent unhandled exceptions by not awaiting tasks concurrently #153

Closed TheMulhima closed 1 year ago

TheMulhima commented 1 year ago

by doing (await ml, await al), if al threw before ml was fully awaited, it would cause an unhandled exception (because different thread so the try catch in MainWindowViewModel wouldn't catch it). This would lead to scarab just showing blank screen with no error or anything. Although it's less efficient, its better to handle errors properly

TheMulhima commented 1 year ago

If you want to reproduce the bug just turn off wifi and open scarab again and again until it happens. With being offline it happened around 25% of the time for me

fifty-six commented 1 year ago

Thank you!