search

fightbulc / simplon_mysql

MySQL PDO Wrapper (php, mysql, pdo, crud, library)
70 stars 22 forks source link

Readme claims PHP >= 5.3 but 5.4 needed due to [] array notation #7

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hi,

in Crud\SqlCrudManager Line 179 you are using PHP 5.4 [] array notation

        // build result
        $sqlCrudInterfaceMany = [];

Are you relying on any other 5.4 features in your code? If so, could you update the readme accordingly. If not useage of $sqlCrudInterfaceMany = array(); would be a good idea.

regards

fightbulc commented 9 years ago

Hey there. Thanks for the catch.

PHP54 notations find their way sometimes into small updates, unfortunately. Will fix that.

Cheers

fightbulc commented 9 years ago

Fixed: https://github.com/fightbulc/simplon_mysql/releases/tag/0.4.4