challenges property is missing from ParticipantDTO

[safranx]

Hi dear fightmegg team,

First of all, your lib is a pleasure to use 💯 But (there is always a but 😄), I noticed that the challenges property is not part of the ParticipantDTO type. The challenge properties are very interresting to use.

"challenges": {
  "12AssistStreakCount": 0,
  "abilityUses": 543,
  "acesBefore15Minutes": 0,
  "alliedJungleMonsterKills": 4,
  "baronBuffGoldAdvantageOverThreshold": 1,
  "baronTakedowns": 1,
  "blastConeOppositeOpponentCount": 0,
  "bountyGold": 0,
  "buffsStolen": 0,
  "completeSupportQuestInTime": 0,
  "controlWardTimeCoverageInRiverOrEnemyHalf": 0.7825029368041099,
  "controlWardsPlaced": 5,
  "damagePerMinute": 620.3165226502967,
  "damageTakenOnTeamPercentage": 0.1545613933307967,
  "dancedWithRiftHerald": 0,
  "deathsByEnemyChamps": 4,
  "dodgeSkillShotsSmallWindow": 0,
  "doubleAces": 0,
  "dragonTakedowns": 0,
  "earliestBaron": 1550.4271658,
  "earlyLaningPhaseGoldExpAdvantage": 0,
  "effectiveHealAndShielding": 0,
  "elderDragonKillsWithOpposingSoul": 0,
  "elderDragonMultikills": 0,
  "enemyChampionImmobilizations": 12,
  "enemyJungleMonsterKills": 0,
  "epicMonsterKillsNearEnemyJungler": 0,
  "epicMonsterKillsWithin30SecondsOfSpawn": 0,
  "epicMonsterSteals": 0,
  "epicMonsterStolenWithoutSmite": 0,
  "firstTurretKilled": 1,
  "firstTurretKilledTime": 850.4393387,
  "flawlessAces": 1,
  "fullTeamTakedown": 0,
  "gameLength": 1684.4324015999998,
  "getTakedownsInAllLanesEarlyJungleAsLaner": 0,
  "goldPerMinute": 438.9545446348413,
  "hadOpenNexus": 0,
  "immobilizeAndKillWithAlly": 1,
  "initialBuffCount": 0,
  "initialCrabCount": 0,
  "jungleCsBefore10Minutes": 0,
  "junglerTakedownsNearDamagedEpicMonster": 0,
  "kTurretsDestroyedBeforePlatesFall": 0,
  "kda": 0.5,
  "killAfterHiddenWithAlly": 0,
  "killParticipation": 0.08333333333333333,
  "killedChampTookFullTeamDamageSurvived": 0,
  "killingSprees": 0,
  "killsNearEnemyTurret": 1,
  "killsOnOtherLanesEarlyJungleAsLaner": 0,
  "killsOnRecentlyHealedByAramPack": 0,
  "killsUnderOwnTurret": 0,
  "killsWithHelpFromEpicMonster": 0,
  "knockEnemyIntoTeamAndKill": 0,
  "landSkillShotsEarlyGame": 15,
  "laneMinionsFirst10Minutes": 82,
  "laningPhaseGoldExpAdvantage": 0,
  "legendaryCount": 0,
  "legendaryItemUsed": [
      6657,
      3003,
      3089
  ],
  "lostAnInhibitor": 0,
  "maxCsAdvantageOnLaneOpponent": 139,
  "maxKillDeficit": 9,
  "maxLevelLeadLaneOpponent": 3,
  "mejaisFullStackInTime": 0,
  "moreEnemyJungleThanOpponent": 0,
  "multiKillOneSpell": 0,
  "multiTurretRiftHeraldCount": 0,
  "multikills": 0,
  "multikillsAfterAggressiveFlash": 0,
  "outerTurretExecutesBefore10Minutes": 0,
  "outnumberedKills": 0,
  "outnumberedNexusKill": 0,
  "perfectDragonSoulsTaken": 0,
  "perfectGame": 0,
  "pickKillWithAlly": 1,
  "playedChampSelectPosition": 1,
  "poroExplosions": 0,
  "quickCleanse": 0,
  "quickFirstTurret": 0,
  "quickSoloKills": 0,
  "riftHeraldTakedowns": 0,
  "saveAllyFromDeath": 0,
  "scuttleCrabKills": 1,
  "skillshotsDodged": 10,
  "skillshotsHit": 65,
  "snowballsHit": 0,
  "soloBaronKills": 0,
  "soloKills": 1,
  "soloTurretsLategame": 1,
  "stealthWardsPlaced": 3,
  "survivedSingleDigitHpCount": 0,
  "survivedThreeImmobilizesInFight": 0,
  "takedownOnFirstTurret": 1,
  "takedowns": 2,
  "takedownsAfterGainingLevelAdvantage": 0,
  "takedownsBeforeJungleMinionSpawn": 0,
  "takedownsFirstXMinutes": 1,
  "takedownsInAlcove": 0,
  "takedownsInEnemyFountain": 0,
  "teamBaronKills": 1,
  "teamDamagePercentage": 0.2125757250000155,
  "teamElderDragonKills": 0,
  "teamRiftHeraldKills": 1,
  "tookLargeDamageSurvived": 0,
  "turretPlatesTaken": 3,
  "turretTakedowns": 4,
  "turretsTakenWithRiftHerald": 0,
  "twentyMinionsIn3SecondsCount": 0,
  "twoWardsOneSweeperCount": 0,
  "unseenRecalls": 0,
  "visionScoreAdvantageLaneOpponent": 0.19000446796417236,
  "visionScorePerMinute": 0.9879044502500595,
  "wardTakedowns": 4,
  "wardTakedownsBefore20M": 2,
  "wardsGuarded": 0,
  },

Do you think a active contributor will be able to add it quickly? If not I can propose a PR!

Best,

[safranx]

I push a PR but maintainer (@OllieJennings, @francois-blanchard, @bwwhite, @Darkbound) have to review and accept it 😃

Btw I don't know why ci/circleci: tests-e2e is failling 😢

[francois-blanchard]

Hi @safranx 👋 Nice to meet you.

I'll have a look at your PR.

About the tests-e2e, I had the same issue. It's because you need to get @OllieJennings's RIOT API token, and you don't have access to it. It's likely provided by a CircleCI context that is private.

[safranx]

Ceci explique cela haha 😄

Thank you for the review @francois-blanchard!

[OllieJennings]

Yeah annoying that is the case, l wanted to try and get a "public" ish API key from Riot but they told me l had to keep it secret. Going to get this MR in this weekend, apologies for the delay

[OllieJennings]

Done in: : https://github.com/fightmegg/riot-api/pull/547