search

figiel / hosts

a libc wrapper providing per-user hosts file
Creative Commons Zero v1.0 Universal
65 stars 12 forks source link

rename libhostspriv.so to libuserhosts.so #8

Closed bobvanderlinden closed 3 years ago

bobvanderlinden commented 3 years ago

I'd like to package hosts/libhostspriv.so for Nix. I ran into this project due to https://discourse.nixos.org/t/change-etc-hosts-using-shell-nix/9335/13 and I think it can help out quite a bit for Nix users.

However, the naming is a bit confusing. I'm not sure I can introduce a package called hosts. In addition, libhostspriv.so is named differently, which can be confusing.

That's why I'd like to suggest renaming the project from hosts/libhostspriv.so to userhosts/libuserhosts.so. I can totally understand if this is unwanted. But I thought I'd suggest it before creating the actual package. Let me know what you think.

I also added support to do make install so that packaging will likely be straightforward.

figiel commented 3 years ago

I'm fine with the change.

bobvanderlinden commented 3 years ago

Thanks for merging! 😄👍 Could you create a version tag so that I can use that version for the package of userhosts?

figiel commented 3 years ago

Done, it's v1.0.0.

bobvanderlinden commented 3 years ago

Thanks! Created a PR to add it to nixpkgs: https://github.com/NixOS/nixpkgs/pull/130045