Open andreincu opened 5 months ago
Will flag internally! Seems like a good improvement overall.
Should I create another ticket for layoutGrids
as well?
Or is sufficient to leave it here in the comments:
type MinimalLayoutGridMixin = Pick<BaseFrameMixin, 'layoutGrids' | 'gridStyleId' | 'setGridStyleIdAsync'>;
Ofc, in your case, you'll need to define and extend the BaseFrameMixin.
@andreincu Could you clarify what the purpose of this change is? It seems like after this change, BlendMixin
would be the only interface to inherit from MinimalEffectsMixin
, which seems like it could be a premature abstraction.
Hi @jefflee-figma,
I proposed this change for mainly 2 reasons:
Exclude<SceneNode, MinimalEffectsMixin>
this way I can quickly verify the scenarios where effects do not exists.
This is a feature request for adding MinimalEffectsMixin for being consistent with the rest, plus adding the ability to extract nodes that support effects.
Before:
After:
This will allow doing the following:
https://github.com/figma/plugin-typings/blob/67cdb4a189db19caa1d4e5f87971e7a3931e273b/plugin-api.d.ts#L1626C1-L1627C24