search

figurenz / microsite-pacific

https://pacific.figure.nz/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

iPhone horizontal view image crop #57

Open natdudley opened 3 years ago

natdudley commented 3 years ago

on iPhone horizontally, the image of the samoan lady crops poorly.

IMG_0528

It's unfortunate but not a blocking issue as rare to view site this way.

Issue stems from max height of issue being set to % of viewport. I'll have a look at options.

robisaacnz commented 3 years ago

I have some (limited) scope to crop the source image we use differently, to help push it in the right direction, but we're using most of the image already.

natdudley commented 3 years ago

Yeah. because we had longer title I chose a portrait image which is what has caused this issue.

I could also play around with the flex proportions?

Maybe for viewport widths less than 850 (i.e., when vertical flex kicks in), I remove the viewport height restriction.

natdudley commented 3 years ago

Downside is it means you have a big image to scroll past, but maybe that's OK?

natdudley commented 3 years ago

Note: changes to this would also impact iPad pro in some aspect ratios. Need to test any changes there too.