search

figurenz / microsite-pacific

https://pacific.figure.nz/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Update jQuery version #74

Closed natdudley closed 3 years ago

natdudley commented 3 years ago

Existing version of jQuery has vulnerabilities. It's not required for the site build, only for keyboard interaction.

We're using a minified version from their CDN, so have updated to most recent version. No regressions detected, but this will need testing

Fix #66

robisaacnz commented 3 years ago

Without any unit tests before this point, we have no useful way to detect regressions due to a patch like this. I say we YOLO it, and the sooner we're eating the dogfood the sooner we'll know it broke.