fiji-flo / x1carbon2018s3

S3 suspend for the X1 Carbon 2018
The Unlicense
165 stars 16 forks source link

track pad/track point gone after resume #16

Closed katakombi closed 6 years ago

katakombi commented 6 years ago

I've got deep sleep working on Linux Mint working following these instructions (see also #15 ) One problem remains, however, and that's after resume the track pad and the track point is non-functional. Seems like even the device went missing - in the control center it is supposed to be shown next to the "mouse" settings and now it is gone. For other sleep modes I used the following script on wakeup which helped to get it back:

cat /lib/systemd/system-sleep/trackpoint 
#!/bin/sh

# Reinitialize Touch Pad to fix non-working Track Point

case $1 in
    post)
    echo -n none > /sys/devices/platform/i8042/serio1/drvctl
    sleep 1
    echo -n reconnect > /sys/devices/platform/i8042/serio1/drvctl
    sleep 1
    synclient TapButton1=1 TapButton2=2 TapButton3=3
;;
esac

My grub commandline

cat /etc/default/grub | grep CMDLINE
GRUB_CMDLINE_LINUX_DEFAULT="quiet splash psmouse.synaptics_intertouch=1 iwlwifi.power_save=1 iwlwifi.d0i3_disable=0 iwlwifi=uapsd_disable=0 thinkpad_acpi.fan_control=1 mem_sleep_default=deep"
GRUB_CMDLINE_LINUX=""

My kernel version

uname -a
Linux melisandre 4.17.8-041708-generic #201807180730 SMP Wed Jul 18 07:32:29 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

It does not work here. Anyone facing similar issues?

fiji-flo commented 6 years ago

Maybe this is an issue with the synaptics driver. I'm using libinput and everything works fine. Is synaptics default on Mint, or do you just prefer their behavior?

katakombi commented 6 years ago

They actually do not set it as default as of Linux Mint 19 any longer. I tried libinput but the motion settings come not even close to how conveniently acceleration and tapping work with synaptics. As long as I used s2idle I had no troubles using synaptics. So maybe I'll test Si03 again...

katakombi commented 6 years ago

Okay I've double-checked it, and here's the thing:

I have the model with NFC and I've read somewhere that the track pad issues are worse there. It's a shame but most likely I'm going to return the device fully functional sleep mode with track pad / track point is crucial to me.

HenrikBengtsson commented 6 years ago

I also observed about ~2-3W power consumption during sleep also after having enabled S3 sleep mode:

$ dmesg | grep -i "acpi: (supports"
[    0.143737] ACPI: (supports S0 S3 S4 S5)

Comment: I'm a rookie when it comes to parsing and troubleshooing the boot logs (dmseg), but as far as I could tell, I did at least not see any errors, so I think I've applied my tweaks correctly.

This morning, I found a comment about launching the kernel with command-line option acpi.ec_no_wakeup=1 (*):

This acpi param is supported from ​v4.13, it is simple to reduce the power consumption.

If it meets your requirement, then no need to patch DSDT which is more complex.

Power button can wake up system.

My kernel is (>= 4.13):

uname -a
Linux hb-x1 4.15.0-29-generic #31-Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

After adding this (sudo emacs /etc/default/grub, appended acpi.ec_no_wakeup=1 to GRUB_CMDLINE_LINUX_DEFAULT="...", saved, then sudo update-grub), and rebooting, I did a couple of 30-90 minute sleeps, and am now seeing ~0.65W during sleep. Yeah! From 'Power Statistics' Ubuntu 18.04 and also:

2018-07-29 11:15:48$ upower -i $(upower -e | grep BAT)
  native-path:          BAT0
  vendor:               SMP
  model:                01AV431
  serial:               4825
  power supply:         yes
  updated:              Sun 29 Jul 2018 11:15:39 AM CEST (10 seconds ago)
  has history:          yes
  has statistics:       yes
  battery
    present:             yes
    rechargeable:        yes
    state:               discharging
    warning-level:       none
    energy:              56.85 Wh
    energy-empty:        0 Wh
    energy-full:         58.37 Wh
    energy-full-design:  57.02 Wh
    energy-rate:         0.658 W
    voltage:             12.903 V
    time to empty:       3.6 days
    percentage:          97%
    capacity:            100%
    technology:          lithium-polymer
    icon-name:          'battery-full-symbolic'
  History (charge):
    1532855739  97.000  discharging
  History (rate):
    1532855739  0.658   discharging

(*) According to that comment, the DSDT patch is not needed for this. I don't know how to undo the patch, so I cannot confirm. Will reflashing BIOS 1.25 remove the DSDT patch?

System Details

fiji-flo commented 6 years ago

Closing this, since Lenovo added S3 support.