search

fiji-flo / x1carbon2018s3

S3 suspend for the X1 Carbon 2018
The Unlicense
165 stars 16 forks source link

generate and apply patch failed on Ubuntu... #24

Closed Callek closed 6 years ago

Callek commented 6 years ago

LOG:

# ./generate_and_apply_patch.sh 
[*] Installing required tools
Reading package lists... Done
Building dependency tree       
Reading state information... Done
cpio is already the newest version (2.12+dfsg-6).
acpica-tools is already the newest version (20180105-1).
The following packages were automatically installed and are no longer required:
  linux-headers-4.15.0-29 linux-headers-4.15.0-29-generic linux-headers-4.15.0-30 linux-headers-4.15.0-30-generic
  linux-image-4.15.0-29-generic linux-image-4.15.0-30-generic linux-modules-4.15.0-29-generic
  linux-modules-4.15.0-30-generic linux-modules-extra-4.15.0-29-generic linux-modules-extra-4.15.0-30-generic
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 9 not upgraded.
[*] Dumping DSDT
[*] Decompiling DSDT

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20180105
Copyright (c) 2000 - 2018 Intel Corporation

Input file dsdt.dat, Length 0x26188 (156040) bytes
ACPI: DSDT 0x0000000000000000 026188 (v02 LENOVO SKL      00000000 INTL 20160527)
Pass 1 parse of [DSDT]
Pass 2 parse of [DSDT]
Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)

Parsing completed
Disassembly completed
ASL Output:    dsdt.dsl - 1078011 bytes
[*] Patching DSDT
[*] Compiling DSDT

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20180105
Copyright (c) 2000 - 2018 Intel Corporation

dsdt.dsl    274:     Method (DX2H, 2, Serialized)
Error    6074 -                ^ Name already exists in scope (DX2H)

    Original name creation/declaration below: 
    dsdt.dsl    208:     External (DX2H, MethodObj)    // 2 Arguments

dsdt.dsl    326:     Method (MBGS, 1, Serialized)
Error    6074 -                ^ Name already exists in scope (MBGS)

    Original name creation/declaration below: 
    dsdt.dsl    218:     External (MBGS, MethodObj)    // 1 Arguments

dsdt.dsl    448:         BNUM,   8, 
Error    6074 -            ^ Name already exists in scope (BNUM)

    Original name creation/declaration below: 
    dsdt.dsl    204:     External (BNUM, UnknownObj)

dsdt.dsl   1409:         ODV0,   8, 
Error    6074 -            ^ Name already exists in scope (ODV0)

    Original name creation/declaration below: 
    dsdt.dsl    221:     External (ODV0, IntObj)

dsdt.dsl   1410:         ODV1,   8, 
Error    6074 -            ^ Name already exists in scope (ODV1)

    Original name creation/declaration below: 
    dsdt.dsl    222:     External (ODV1, IntObj)

dsdt.dsl   1411:         ODV2,   8, 
Error    6074 -            ^ Name already exists in scope (ODV2)

    Original name creation/declaration below: 
    dsdt.dsl    223:     External (ODV2, IntObj)

dsdt.dsl   1412:         ODV3,   8, 
Error    6074 -            ^ Name already exists in scope (ODV3)

    Original name creation/declaration below: 
    dsdt.dsl    224:     External (ODV3, IntObj)

dsdt.dsl   1413:         ODV4,   8, 
Error    6074 -            ^ Name already exists in scope (ODV4)

    Original name creation/declaration below: 
    dsdt.dsl    225:     External (ODV4, IntObj)

dsdt.dsl   1414:         ODV5,   8, 
Error    6074 -            ^ Name already exists in scope (ODV5)

    Original name creation/declaration below: 
    dsdt.dsl    226:     External (ODV5, IntObj)

dsdt.dsl   1571:         ODV6,   8, 
Error    6074 -            ^ Name already exists in scope (ODV6)

    Original name creation/declaration below: 
    dsdt.dsl    227:     External (ODV6, IntObj)

dsdt.dsl   1572:         ODV7,   8, 
Error    6074 -            ^ Name already exists in scope (ODV7)

    Original name creation/declaration below: 
    dsdt.dsl    228:     External (ODV7, IntObj)

dsdt.dsl   1573:         ODV8,   8, 
Error    6074 -            ^ Name already exists in scope (ODV8)

    Original name creation/declaration below: 
    dsdt.dsl    229:     External (ODV8, IntObj)

dsdt.dsl   1574:         ODV9,   8, 
Error    6074 -            ^ Name already exists in scope (ODV9)

    Original name creation/declaration below: 
    dsdt.dsl    230:     External (ODV9, IntObj)

dsdt.dsl   1575:         ODVA,   8, 
Error    6074 -            ^ Name already exists in scope (ODVA)

    Original name creation/declaration below: 
    dsdt.dsl    231:     External (ODVA, IntObj)

dsdt.dsl   1576:         ODVB,   8, 
Error    6074 -            ^ Name already exists in scope (ODVB)

    Original name creation/declaration below: 
    dsdt.dsl    232:     External (ODVB, IntObj)

dsdt.dsl   1577:         ODVC,   8, 
Error    6074 -            ^ Name already exists in scope (ODVC)

    Original name creation/declaration below: 
    dsdt.dsl    233:     External (ODVC, IntObj)

dsdt.dsl   1578:         ODVD,   8, 
Error    6074 -            ^ Name already exists in scope (ODVD)

    Original name creation/declaration below: 
    dsdt.dsl    234:     External (ODVD, IntObj)

dsdt.dsl   1579:         ODVE,   8, 
Error    6074 -            ^ Name already exists in scope (ODVE)

    Original name creation/declaration below: 
    dsdt.dsl    235:     External (ODVE, IntObj)

dsdt.dsl   1580:         ODVF,   8, 
Error    6074 -            ^ Name already exists in scope (ODVF)

    Original name creation/declaration below: 
    dsdt.dsl    236:     External (ODVF, IntObj)

dsdt.dsl   1581:         ODVG,   8, 
Error    6074 -            ^ Name already exists in scope (ODVG)

    Original name creation/declaration below: 
    dsdt.dsl    237:     External (ODVG, IntObj)

dsdt.dsl   1582:         ODVH,   8, 
Error    6074 -            ^ Name already exists in scope (ODVH)

    Original name creation/declaration below: 
    dsdt.dsl    238:     External (ODVH, IntObj)

dsdt.dsl   1583:         ODVI,   8, 
Error    6074 -            ^ Name already exists in scope (ODVI)

    Original name creation/declaration below: 
    dsdt.dsl    239:     External (ODVI, IntObj)

dsdt.dsl   1584:         ODVJ,   8, 
Error    6074 -            ^ Name already exists in scope (ODVJ)

    Original name creation/declaration below: 
    dsdt.dsl    240:     External (ODVJ, IntObj)

dsdt.dsl   3642:                 Device (PEG0)
Error    6074 -                            ^ Name already exists in scope (PEG0)

    Original name creation/declaration below: 
    dsdt.dsl     78:     External (_SB_.PCI0.PEG0, DeviceObj)

dsdt.dsl   3645:                     Device (PEGP)
Error    6074 -   Name already exists in scope ^  (PEGP)

    Original name creation/declaration below: 
    dsdt.dsl     79:     External (_SB_.PCI0.PEG0.PEGP, DeviceObj)

dsdt.dsl   3651:                 Device (PEG1)
Error    6074 -                            ^ Name already exists in scope (PEG1)

    Original name creation/declaration below: 
    dsdt.dsl     81:     External (_SB_.PCI0.PEG1, DeviceObj)

dsdt.dsl   3660:                 Device (PEG2)
Error    6074 -                            ^ Name already exists in scope (PEG2)

    Original name creation/declaration below: 
    dsdt.dsl     83:     External (_SB_.PCI0.PEG2, DeviceObj)

dsdt.dsl   3669:                 Device (GFX0)
Error    6074 -                            ^ Name already exists in scope (GFX0)

    Original name creation/declaration below: 
    dsdt.dsl     55:     External (_SB_.PCI0.GFX0, DeviceObj)

dsdt.dsl   3692:                 Device (ISP0)
Error    6074 -                            ^ Name already exists in scope (ISP0)

    Original name creation/declaration below: 
    dsdt.dsl     74:     External (_SB_.PCI0.ISP0, DeviceObj)

dsdt.dsl   4340:         Method (GGIV, 1, Serialized)
Error    6074 -                    ^ Name already exists in scope (GGIV)

    Original name creation/declaration below: 
    dsdt.dsl     48:     External (_SB_.GGIV, MethodObj)    // 1 Arguments

dsdt.dsl   4356:         Method (GGOV, 1, Serialized)
Error    6074 -                    ^ Name already exists in scope (GGOV)

    Original name creation/declaration below: 
    dsdt.dsl     49:     External (_SB_.GGOV, MethodObj)    // 1 Arguments

dsdt.dsl   4371:         Method (SGOV, 2, Serialized)
Error    6074 -                    ^ Name already exists in scope (SGOV)

    Original name creation/declaration below: 
    dsdt.dsl    195:     External (_SB_.SGOV, MethodObj)    // 2 Arguments

dsdt.dsl   6771:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl     87:     External (_SB_.PCI0.RP01.PXSX, DeviceObj)

dsdt.dsl   7028:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl     91:     External (_SB_.PCI0.RP02.PXSX, DeviceObj)

dsdt.dsl   7285:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl     95:     External (_SB_.PCI0.RP03.PXSX, DeviceObj)

dsdt.dsl   7542:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl     99:     External (_SB_.PCI0.RP04.PXSX, DeviceObj)

dsdt.dsl   7799:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    104:     External (_SB_.PCI0.RP05.PXSX, DeviceObj)

dsdt.dsl   8056:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    110:     External (_SB_.PCI0.RP06.PXSX, DeviceObj)

dsdt.dsl   8313:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    114:     External (_SB_.PCI0.RP07.PXSX, DeviceObj)

dsdt.dsl   8570:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    118:     External (_SB_.PCI0.RP08.PXSX, DeviceObj)

dsdt.dsl   8827:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    124:     External (_SB_.PCI0.RP09.PXSX, DeviceObj)

dsdt.dsl   9084:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    130:     External (_SB_.PCI0.RP10.PXSX, DeviceObj)

dsdt.dsl   9341:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    134:     External (_SB_.PCI0.RP11.PXSX, DeviceObj)

dsdt.dsl   9598:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    138:     External (_SB_.PCI0.RP12.PXSX, DeviceObj)

dsdt.dsl   9855:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    143:     External (_SB_.PCI0.RP13.PXSX, DeviceObj)

dsdt.dsl  10112:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    149:     External (_SB_.PCI0.RP14.PXSX, DeviceObj)

dsdt.dsl  10369:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    153:     External (_SB_.PCI0.RP15.PXSX, DeviceObj)

dsdt.dsl  10626:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    157:     External (_SB_.PCI0.RP16.PXSX, DeviceObj)

dsdt.dsl  10883:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    162:     External (_SB_.PCI0.RP17.PXSX, DeviceObj)

dsdt.dsl  11140:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    168:     External (_SB_.PCI0.RP18.PXSX, DeviceObj)

dsdt.dsl  11397:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    172:     External (_SB_.PCI0.RP19.PXSX, DeviceObj)

dsdt.dsl  11654:             Device (PXSX)
Error    6074 -                        ^ Name already exists in scope (PXSX)

    Original name creation/declaration below: 
    dsdt.dsl    176:     External (_SB_.PCI0.RP20.PXSX, DeviceObj)

dsdt.dsl  19126:     Method (TBTD, 1, Serialized)
Error    6074 -                ^ Name already exists in scope (TBTD)

    Original name creation/declaration below: 
    dsdt.dsl    260:     External (TBTD, MethodObj)    // 1 Arguments

dsdt.dsl  19194:     Method (TBTF, 1, Serialized)
Error    6074 -                ^ Name already exists in scope (TBTF)

    Original name creation/declaration below: 
    dsdt.dsl    261:     External (TBTF, MethodObj)    // 1 Arguments

dsdt.dsl  19299:     Method (MMRP, 1, Serialized)
Error    6074 -                ^ Name already exists in scope (MMRP)

    Original name creation/declaration below: 
    dsdt.dsl    219:     External (MMRP, MethodObj)    // 1 Arguments

dsdt.dsl  19307:     Method (MMTB, 1, Serialized)
Error    6074 -                ^ Name already exists in scope (MMTB)

    Original name creation/declaration below: 
    dsdt.dsl    220:     External (MMTB, MethodObj)    // 1 Arguments

dsdt.dsl  19419:     Method (ADBG, 1, Serialized)
Error    6074 -                ^ Name already exists in scope (ADBG)

    Original name creation/declaration below: 
    dsdt.dsl    202:     External (ADBG, MethodObj)    // 1 Arguments

dsdt.dsl  21625:         Method (TBFP, 1, NotSerialized)
Error    6074 -                    ^ Name already exists in scope (TBFP)

    Original name creation/declaration below: 
    dsdt.dsl    196:     External (_SB_.TBFP, MethodObj)    // 1 Arguments

dsdt.dsl  22437:         Processor (PR00, 0x01, 0x00001810, 0x06){}
Error    6074 -                       ^ Name already exists in scope (PR00)

    Original name creation/declaration below: 
    dsdt.dsl     43:     External (_PR_.PR00, DeviceObj)

dsdt.dsl  23067:         Method (TBNF, 0, NotSerialized)
Error    6074 -                    ^ Name already exists in scope (TBNF)

    Original name creation/declaration below: 
    dsdt.dsl     23:     External (_GPE.TBNF, MethodObj)    // 0 Arguments

dsdt.dsl  23111:         Method (WIST, 0, Serialized)
Error    6074 -                    ^ Name already exists in scope (WIST)

    Original name creation/declaration below: 
    dsdt.dsl     89:     External (_SB_.PCI0.RP01.PXSX.WIST, MethodObj)    // 0 Arguments

dsdt.dsl  23187:         Method (WGST, 0, Serialized)
Error    6074 -                    ^ Name already exists in scope (WGST)

    Original name creation/declaration below: 
    dsdt.dsl     88:     External (_SB_.PCI0.RP01.PXSX.WGST, MethodObj)    // 0 Arguments

dsdt.dsl  27944:         STDV,   8, 
Error    6074 -            ^ Name already exists in scope (STDV)

    Original name creation/declaration below: 
    dsdt.dsl    259:     External (STDV, IntObj)

dsdt.dsl  33851:         Method (DYTC, 1, Serialized)
Error    6074 -                    ^ Name already exists in scope (DYTC)

    Original name creation/declaration below: 
    dsdt.dsl     75:     External (_SB_.PCI0.LPCB.EC__.HKEY.DYTC, MethodObj)    // 1 Arguments

ASL Input:     dsdt.dsl - 34833 lines, 1078091 bytes, 15321 keywords
Hex Dump:      dsdt.hex - 1361808 bytes

Compilation complete. 64 Errors, 332 Warnings, 116 Remarks, 6298 Optimizations, 46 Constants Folded

After this ran I tried the followon steps to enable it on ubuntu 18.04 (grub2) by editing line 314 in /etc/grub.d/10-linux and then running update-grub2 as suggested in #22 but then I had boot failures so I needed to edit my startup command manually to resume...

thfre commented 6 years ago

I think I stumbled on the same issue the exact moment you did. And I too had to edit grup to resume startup.

kdkavanagh commented 6 years ago

Try upgrading iasl - The one packaged with Ubuntu seems to be a bit older. Compiling the source from https://www.acpica.org/downloads (and installing the two stated deps) fixed the issue for me

SuperQ commented 6 years ago

I verified that backporting acpica-tools 20180629-1 from cosmic works.

fiji-flo commented 6 years ago

Closing this, since Lenovo added S3 support.