search

fiji-flo / x1carbon2018s3

S3 suspend for the X1 Carbon 2018
The Unlicense
165 stars 16 forks source link

Add step to build an updated version of iasl #25

Closed kdkavanagh closed 6 years ago

kdkavanagh commented 6 years ago

Fixes #24

ccressent commented 6 years ago

Thanks for your work @kdkavanagh, and I don't mean to belittle your contribution, but wouldn't it be a nicer fix to get the Ubuntu package for iasl updated instead?

While having an "automagic" script may be convenient, it makes the script grow complex with every single corner case we find. My opinion is that if the script relies on a minimum version of iasl to work, it should check that that condition is met and just tell the user if it's not. The user would then be responsible for making an acceptable version of iasl available to the script, which is a task that varies with Linux distro, user preference, ...

I would keep the version check from your patch, but only tell the user to upgrade iasl if needed (potentially with some instructions to do so) instead of downloading, compiling and running software automatically!

fiji-flo commented 6 years ago

Sorry for not merging this sooner. I was on vacation. Thanks a lot for your effort and for being part of getting Lenovo to release a fix. But since Lenovo fixed this I won't change the script anymore.

Callek commented 6 years ago

Wait it's been fixed, what bios version? As far as I could tell my x1 carbon gen 6 is still having bios issues (~2w per hour)

fiji-flo commented 6 years ago

https://github.com/fiji-flo/x1carbon2018s3#discontinued-fixed-by-lenovo-in-new-firmware-release

They added an option to enable S3 support in the BIOS (v1.30).

ryankhart commented 5 years ago

Sorry for not merging this sooner. I was on vacation. Thanks a lot for your effort and for being part of getting Lenovo to release a fix. But since Lenovo fixed this I won't change the script anymore.

It's still worth merging as this fix still works for the X1 Yoga 3rd Gen. I ran into this same issue, and I still have to use this tool to get S3 to work on Linux.