search

fiji-flo / x1carbon2018s3

S3 suspend for the X1 Carbon 2018
The Unlicense
165 stars 16 forks source link

Adding override configuration of Grub2 #26

Closed DanielTimLee closed 6 years ago

DanielTimLee commented 6 years ago

Override configuration of Grub2

DanielTimLee commented 6 years ago

BTW, just wondering how about informing this issue from Readme. It might be helpful to some.

https://bugzilla.kernel.org/show_bug.cgi?id=199057

(It's related to X1 Yoga 2016, but still the issue for mine in X1C6 Manjaro)

ccressent commented 6 years ago

You shouldn't directly edit /boot/grub/grub.conf!

~$ head -n5 /boot/grub/grub.cfg
#
# DO NOT EDIT THIS FILE
#
# It is automatically generated by grub-mkconfig using templates
# from /etc/grub.d and settings from /etc/default/grub

Especially not on Arch or Manjaro, because your edit will be gone the next time grub-mkconfig is used to regenerate a new /boot/grub/grub.conf, which a kernel upgrade via pacman will do!

Since you're using GRUB2, you could have it load the ACPI override directly as explained in #14. Alternatively, there must be a clean way to have the .img file detected and automatically added to /boot/grub/grub.conf since this is what happens with intel-ucode.img, as described here.

fiji-flo commented 6 years ago

Sorry for not merging this sooner. I was on vacation. Thanks a lot for your effort and for being part of getting Lenovo to release a fix. I won't change the README anymore since there's no point besides being a lesson in history :D