fiji / Colocalisation_Analysis

Fiji's plugin for colocalization analysis
http://imagej.net/Coloc_2
GNU General Public License v3.0
24 stars 18 forks source link

Results: add mask type: "none", "ROI" or "mask image" to results output #35

Closed chalkie666 closed 7 years ago

chalkie666 commented 9 years ago

make a new "String, String" result to put in the DataContainer for the type of ROI/mask used, so the user knows after the fact if they used a ROI or mask or not.

etadobson commented 7 years ago

@chalkie666 - Does this refer to:

// enumeration of different mask types
public enum MaskType { Regular, Irregular, None };

So Regular, Irregular, and None represent the different mask statuses, "ROI", "mask image", and "none" respectively? or am I missing something? Then we can just include a String to indicate the maskType, ie String maskStatus?

ctrueden commented 7 years ago

There are advantages (and disadvantages) to strong typing rather than using String. Do the mask types be extensible? If not, they should probably stay as an enum. Otherwise, we could consider an "extensible enum" pattern; here is an example.

ctrueden commented 7 years ago

See also 8ff13666, which added the current mask type logic to DataContainer etc.