search

fiji / Colocalisation_Analysis

Fiji's plugin for colocalization analysis
http://imagej.net/Coloc_2
GNU General Public License v3.0
25 stars 18 forks source link

Add and default to regression pattern used by Costes #5

Closed tomka closed 9 years ago

tomka commented 9 years ago

This pull request adds support for different regression patterns. It also adds an alternative to the current bisection method: a simple regression that decrements values one by one, just as it is used in the Costes paper. Since this is what people are likely to expect, it is now the default. The faster bisection method is still available, but has to be selected by the user.

If there are no changes requested, I'll merge this in a couple of days into master. The pull request is only used for documentation and to allow discussion about this change.

ctrueden commented 9 years ago

I can't comment on the technical approach, since I'm ignorant about colocalization. But the code quality looks great—nice patches. And in general, I am a fan of doing what people expect, instead of what will surprise them.

tomka commented 9 years ago

I should be able to go through this again next week and then finally merge this in.

tomka commented 9 years ago

I looked through everything again, think all the changes are alright and will merge this.

chalkie666 commented 9 years ago

great! thanks @tomka !