fiji / SPIM_Registration

Deprecated, instead check out: https://github.com/preibischLab/multiview-reconstruction & https://github.com/PreibischLab/BigStitcher
GNU General Public License v2.0
23 stars 22 forks source link

Incompatible with BigDataViewer v10 #137

Closed ctrueden closed 2 years ago

ctrueden commented 2 years ago

I am preparing to make a new release of Fiji with newer component versions. Unfortunately, the update of BDV to 10.2.0 breaks compilation of this project:

Build log ``` $ mvn -Dbigdataviewer-core.version=10.2.0 clean test [INFO] Scanning for projects... [INFO] [INFO] ---------------------< sc.fiji:SPIM_Registration >---------------------- [INFO] Building SPIM Registration 5.0.22-SNAPSHOT [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ SPIM_Registration --- [INFO] Deleting /home/curtis/code/fiji/SPIM_Registration/target [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-rules) @ SPIM_Registration --- [INFO] Adding ignore: module-info [INFO] Adding ignore: META-INF/versions/*/module-info [INFO] Adding ignore: com.esotericsoftware.kryo.* [INFO] Adding ignore: com.esotericsoftware.minlog.* [INFO] Adding ignore: com.esotericsoftware.reflectasm.* [INFO] Adding ignore: com.google.inject.* [INFO] Adding ignore: jnr.ffi.* [INFO] Adding ignore: org.apache.hadoop.yarn.*.package-info [INFO] Adding ignore: org.apache.spark.unused.UnusedStubClass [INFO] Adding ignore: org.hibernate.stat.ConcurrentStatisticsImpl [INFO] Adding ignore: org.jetbrains.kotlin.daemon.common.* [INFO] Adding ignore: org.junit.runner.Runner [INFO] Adding ignore: module-info [INFO] Adding ignore: module-info [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:regex-property (sanitize-version) @ SPIM_Registration --- [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:regex-property (guess-package) @ SPIM_Registration --- [INFO] [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ SPIM_Registration --- [INFO] Executing: /bin/sh -c cd '/home/curtis/code/fiji/SPIM_Registration' && 'git' 'rev-parse' '--verify' 'HEAD' [INFO] Working directory: /home/curtis/code/fiji/SPIM_Registration [INFO] Storing buildNumber: 3c6736fe73ed873efa821908e4d172fdd6444cac at timestamp: 1631223027245 [INFO] Storing buildScmBranch: master [INFO] [INFO] --- scijava-maven-plugin:2.0.0:set-rootdir (set-rootdir) @ SPIM_Registration --- [INFO] Setting rootdir: /home/curtis/code/fiji/SPIM_Registration [INFO] [INFO] --- jacoco-maven-plugin:0.8.6:prepare-agent (jacoco-initialize) @ SPIM_Registration --- [INFO] argLine set to -javaagent:/home/curtis/.m2/repository/org/jacoco/org.jacoco.agent/0.8.6/org.jacoco.agent-0.8.6-runtime.jar=destfile=/home/curtis/code/fiji/SPIM_Registration/target/jacoco.exec [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ SPIM_Registration --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ SPIM_Registration --- [INFO] Compiling 405 source files to /home/curtis/code/fiji/SPIM_Registration/target/classes [INFO] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/ViewSetupExplorerPanel.java: Some input files use or override a deprecated API. [INFO] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/ViewSetupExplorerPanel.java: Recompile with -Xlint:deprecation for details. [INFO] /home/curtis/code/fiji/SPIM_Registration/src/main/java/mpicbg/spim/mpicbg/PointMatchGeneric.java: Some input files use unchecked or unsafe operations. [INFO] /home/curtis/code/fiji/SPIM_Registration/src/main/java/mpicbg/spim/mpicbg/PointMatchGeneric.java: Recompile with -Xlint:unchecked for details. [INFO] Some messages have been simplified; recompile with -Xdiags:verbose to get full output [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/interestpoint/InterestPointExplorer.java:[128,82] incompatible types: spim.fiji.spimdata.explorer.interestpoint.InterestPointOverlay cannot be converted to bdv.viewer.TransformListener [ERROR] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/interestpoint/InterestPointExplorer.java:[129,93] incompatible types: spim.fiji.spimdata.explorer.interestpoint.InterestPointOverlay cannot be converted to bdv.viewer.OverlayRenderer [ERROR] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/interestpoint/InterestPointTableModel.java:[244,77] incompatible types: spim.fiji.spimdata.explorer.interestpoint.InterestPointOverlay cannot be converted to bdv.viewer.TransformListener [ERROR] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/interestpoint/InterestPointTableModel.java:[245,82] incompatible types: spim.fiji.spimdata.explorer.interestpoint.InterestPointOverlay cannot be converted to bdv.viewer.OverlayRenderer [INFO] 4 errors [INFO] ------------------------------------------------------------- [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 5.885 s [INFO] Finished at: 2021-09-09T16:30:30-05:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project SPIM_Registration: Compilation failure: Compilation failure: [ERROR] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/interestpoint/InterestPointExplorer.java:[128,82] incompatible types: spim.fiji.spimdata.explorer.interestpoint.InterestPointOverlay cannot be converted to bdv.viewer.TransformListener [ERROR] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/interestpoint/InterestPointExplorer.java:[129,93] incompatible types: spim.fiji.spimdata.explorer.interestpoint.InterestPointOverlay cannot be converted to bdv.viewer.OverlayRenderer [ERROR] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/interestpoint/InterestPointTableModel.java:[244,77] incompatible types: spim.fiji.spimdata.explorer.interestpoint.InterestPointOverlay cannot be converted to bdv.viewer.TransformListener [ERROR] /home/curtis/code/fiji/SPIM_Registration/src/main/java/spim/fiji/spimdata/explorer/interestpoint/InterestPointTableModel.java:[245,82] incompatible types: spim.fiji.spimdata.explorer.interestpoint.InterestPointOverlay cannot be converted to bdv.viewer.OverlayRenderer [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException ```

I wonder if anyone ever uses this component anymore, since no problems have been reported here since 2018, whereas bigdataviewer-core 10.2.0 was uploaded to the Java-8 update site already more than half a year ago (2021-02-22).

@tpietzsch Is this something you can advise on how to fix?

ctrueden commented 2 years ago

Never mind, I figured it out: fc77354c3061771aa13f1e08fa62009fd605dd14

tpietzsch commented 2 years ago

You're just too fast, @ctrueden.