search

fiji / SPIM_Registration

Deprecated, instead check out: https://github.com/preibischLab/multiview-reconstruction & https://github.com/PreibischLab/BigStitcher
GNU General Public License v2.0
23 stars 22 forks source link

Checked compat with JNA 5.11.0 #139

Closed mkitti closed 1 year ago

mkitti commented 2 years ago

Update scijava-pom to 31.1.0 Checked compat with JNA 5.11.0 Use Native.load rather than Native.loadLibrary

xref: https://github.com/scijava/pom-scijava/issues/163

ctrueden commented 1 year ago

@mkitti Uh oh, I just noticed this. Now that we've upgraded Fiji to JNA 5.12.1, but not merged this PR... are there problems with SPIM_Registration? Shall we rebase/update this PR and get it merged?

mkitti commented 1 year ago

Native.loadLibrary is deprecated and should be changed to Native.load.

ctrueden commented 1 year ago

Native.loadLibrary is deprecated and should be changed to Native.load.

@mkitti Noted. But it's just deprecation, not actual breakage, right?

In any case, I rebased the PR, fixed the conflicts, and merged this. Let me know if an immediate release is needed or not.

mkitti commented 1 year ago

I do not think an immediate release is needed.

https://java-native-access.github.io/jna/5.5.0/javadoc/com/sun/jna/Native.html#loadLibrary-java.lang.Class-