search

fiji / SPIM_Registration

Deprecated, instead check out: https://github.com/preibischLab/multiview-reconstruction & https://github.com/PreibischLab/BigStitcher
GNU General Public License v2.0
23 stars 22 forks source link

make TranslationInvariantAffineModel3D and TranslationInvariantSimila… #80

Closed axtimwalde closed 9 years ago

axtimwalde commented 9 years ago

…rityModel3D translation invariant

During including SimilarityModel3D into mpicbg, we realized that

https://github.com/bigdataviewer/SPIM_Registration/blob/master/src/main/java/mpicbg/pointdescriptor/model/TranslationInvariantSimilarityModel3D.java

and

https://github.com/bigdataviewer/SPIM_Registration/blob/master/src/main/java/mpicbg/pointdescriptor/model/TranslationInvariantAffineModel3D.java

are not translation invariant as we believe they were intended. The models estimate an affine relative to the center of mass of all points. We believe that they are supposed to calculate the affine relative to the coordinate origin.

StephanPreibisch commented 9 years ago

Great catch, I never used them :) Thanks so much!!