search

fiji / SPIM_Registration

Deprecated, instead check out: https://github.com/preibischLab/multiview-reconstruction & https://github.com/PreibischLab/BigStitcher
GNU General Public License v2.0
23 stars 22 forks source link

Allow concatenateAxialScaling to work with SimilarityModel3D #95

Closed imagejan closed 8 years ago

imagejan commented 8 years ago

This requires the SimilarityModel3D#set(double, double, double, ...) method introduced in https://github.com/axtimwalde/mpicbg/pull/28, so a new release of mpicbg.jar is required before merging.

This PR fixes concatenation of axial scaling with SimilarityModel3D when using the Descriptor-based (series) registration plugin in Fiji.

imagejan commented 8 years ago

Oh, sorry I didn't follow up on this. As @axtimwalde pointed out in https://github.com/axtimwalde/mpicbg/pull/28 adding z scaling would make the SimilarityModel an AffineModel that wouldn't necessarily be a similarity transform any more. I originally just wanted to avoid the warning "Cannot concatenate axial scaling...". Maybe it would be ok to create a new AffineModel3D with the concatenated scaling for accurate transformation of anisotropic volumes?!

StephanPreibisch commented 8 years ago

Sure, that would be a good option I think …

Cheers, Stephan

On 30 Jun 2016, at 13:40, Jan Eglinger notifications@github.com wrote:

Oh, sorry I didn't follow up on this. As @axtimwalde https://github.com/axtimwalde pointed out in axtimwalde/mpicbg#28 https://github.com/axtimwalde/mpicbg/pull/28 adding z scaling would make the SimilarityModel an AffineModel that wouldn't necessarily be a similarity transform any more. I originally just wanted to avoid the warning "Cannot concatenate axial scaling...". Maybe it would be ok to create a new AffineModel3D with the concatenated scaling for accurate transformation of anisotropic volumes?!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fiji/SPIM_Registration/pull/95#issuecomment-229733534, or mute the thread https://github.com/notifications/unsubscribe/ABWtK9Xf6QMG7RWFVi4S9O_Z64bSD4dYks5qQ_98gaJpZM4IW4K1.