search

fiji / Stitching

Fiji's Stitching plugins reconstruct big images from tiled input images.
http://imagej.net/Stitching
GNU General Public License v2.0
96 stars 64 forks source link

Use 0% by default when stitching from metadata #2

Closed ctrueden closed 10 years ago

ctrueden commented 10 years ago

@bredfeldt wrote:

In Grid/Collection stitching, there is an option for increasing the overlap that is by default set to 10%. This has caused some confusion. When we are stitching using meta data, we don't need to add or increase the overlap at all, so this value should be set to 0%, right? If 0% is the right value, then maybe when it has been selected that we are stitching from meta data, the default value should be 0%, rather than 10%.

Migrated-From: http://dev.loci.wisc.edu/trac/software/ticket/771

ctrueden commented 10 years ago

I think this is a good idea, but @StephanPreibisch: do you agree that the default overlap should become 0% when stitching from metadata? I am not aware of any systems that provide such metadata but would still benefit from additional overlap, but maybe there are some...

StephanPreibisch commented 10 years ago

I do not understand, why would you use the Stitching if there is no overlap anyways, you just need to arrange the tiles then ... then the Stitching does quite some overhead and should maybe not be used, or?

StephanPreibisch commented 10 years ago

Ah I get it now, ok, yes, I agree, the coordinates contain the expected overlap already ... yes, it should be by default 0 when reading from metadata

StephanPreibisch commented 10 years ago

I did set it to 0%, it is already a different number than the "traditional" overlap, it is called "Increase overlap by" ... but if 0% works better, great.

ctrueden commented 10 years ago

Thanks @StephanPreibisch! For reference, the relevant change is a8090c7aa8ea5d6928ed5b2636ca4b793e9e716e.

StephanPreibisch commented 10 years ago

how do you put that into the message? Just copy&paste the link of the commit? https://github.com/fiji/Stitching/commit/a8090c7aa8ea5d6928ed5b2636ca4b793e9e716e Yes, great :)

ctrueden commented 10 years ago

@StephanPreibisch: Yep. For more deliciousness see the docs.