search

fiji / Stitching

Fiji's Stitching plugins reconstruct big images from tiled input images.
http://imagej.net/Stitching
GNU General Public License v2.0
96 stars 64 forks source link

Phase out ImgLib1 #22

Open dscho opened 9 years ago

dscho commented 9 years ago

As agreed between @tpietzsch, @StephanPreibisch, @ctrueden, @hinerm and myself at the ImgLib2 hackathon in May 2013, ImgLib1 is deprecated. Therefore it makes the opposite of sense to release it now. Corollary: Stitching must rid itself from the dependency to be able to be built reproducibly.

This is required before Stitching can re-enter pom-fiji.

axtimwalde commented 9 years ago

I disagree with not `releasing' ImgLib1. I made my opinion clear in another thread and in discussions in October 2014. I disagree that making a non-SNAPSHOT, though deprecated, jar available for legacy compatibility would send confusing signals to anybody. Not doing so hinders progress on other projects for dogmatic and irrelevant reasons.

ctrueden commented 9 years ago

I agree with @axtimwalde, but am willing to compromise if we can find an alternative that @dscho likes and does not hinder progress. @hinerm and I are currently upgrading the whole set of Fiji projects to the latest pom-fiji which includes the ImgLib2 release version. We will address legacy-imglib1 at the end of that process.

ctrueden commented 9 years ago

@StephanPreibisch To help with this, I pushed an update to the latest pom-fiji parent, along with some associated POM cleanup: https://github.com/fiji/Stitching/commit/a5c833e4f213907a5fe2e89734d0a6fd6c4f9121

However, I did not address the usage of ImgLib1. As @dscho says, if you have time to address this, that would be fantastic.

Or if you do not have time to do it, please let us know.

P.S. To build the code from the CLI, you can use the invocation:

mvn -Dscijava.enforce.skip
ctrueden commented 9 years ago

Note that as of 364eddb245b8824eaed24a18ebf2d539293698a3, the build is reproducible thanks to the dependency on sc.fiji:legacy-imglib1:1.0.0-DEPRECATED release version. However, that only achieves the "allow for a first reproducible build" portion of this issue, not the "phase out ImgLib1" portion.