search

fiji / Stitching

Fiji's Stitching plugins reconstruct big images from tiled input images.
http://imagej.net/Stitching
GNU General Public License v2.0
96 stars 64 forks source link

Making useful utility functions public and static so they can be used by other tools #28

Closed kmader closed 9 years ago

kmader commented 9 years ago

Particularly the testCrossCorrelation and findPeaks which are both needed to use the stitching functionality outside of the Stitching_3D plugin

ctrueden commented 9 years ago

@kmader Looks good to me. Do you need testCrossCorrelation to be public, though? It's still private in your patch.

@StephanPreibisch Any objections to merging?

kmader commented 9 years ago

I had made it static so it could be accessed by other static methods, but it could be made public as well. I guess ideally the mpicbg.stitching are the functions we should be using, but the PairWiseStitchingImgLib is still based on imglib1

ctrueden commented 9 years ago

@kmader So you don't need to call testCrossCorrelation from your own code, then? I was assuming you did, since you mentioned it by name in the PR summary. My general advice would be to make public only those methods you actually need to access from your code, since each public method is a commitment to backwards compatibility and makes the code structure more "rigid."