search

fiji / Stitching

Fiji's Stitching plugins reconstruct big images from tiled input images.
http://imagej.net/Stitching
GNU General Public License v2.0
96 stars 64 forks source link

"downsample tiles" corrupts stitching #38

Open aryehw opened 8 years ago

aryehw commented 8 years ago

When I select "downsample tiles", the stitching does something strange. It puts all of my grid of tiles in one row. When I do not down-sample, with all else the same, it works as expected. Do I misunderstand what the downsample option does? I was trying to use it to same space on a really large stitched image.

I attached a screenshot of the stitching parameters. stitchingparameters

ctrueden commented 7 years ago

Apologies for the long delay in reply here. I guess I am ostensibly the one who has to support the downsampling feature, since a former LOCI programmer added it, and @StephanPreibisch knows basically nothing about it.

Do I misunderstand what the downsample option does?

Nope—it is supposed to simply save memory and processing power, by working on smaller versions of your tiles. It sounds like you probably found a bug.

I assume you never found a workaround, and that this is still a problem, so I leave the issue open. But I'm afraid I have no time to even attempt reproducing this bug, much less fixing it.

The good news is that @StephanPreibisch is on the cusp of releasing his next major iteration of the stitching plugin, which will maybe make this issue moot. Fingers crossed.

lguerard commented 1 year ago

Hi Curtis,

I'm also having issues with the downsampling option of this plugin so I'm guessing this has still not been resolved... More information available here.

It seems that reading the tile position from file messes up the downsample position somehow...

ctrueden commented 1 year ago

@lguerard If you have time to investigate and file a PR, I would try to get it merged and released quickly. Unfortunately, I don't have time to work on it myself.

lguerard commented 1 year ago

@ctrueden I managed to have my issue fixed by changing just one line as you can see from https://github.com/fiji/Stitching/pull/69

Was there a reason to only do the downsampling if GridType was 5 or 7 ?