Fix error in the multi threaded version of the Hessian feature calculation.

fiji / Trainable_Segmentation

Fiji library to perform image segmentation based on the Weka learning schemes

https://imagej.net/Trainable_Weka_Segmentation

GNU General Public License v3.0

106 stars 60 forks source link

Fix error in the multi threaded version of the Hessian feature calculation. #36

Closed maarzt closed 7 years ago

maarzt commented 7 years ago

That's in this PR:

Added a test for feature generation with default settings.
Revert commit https://github.com/fiji/Trainable_Segmentation/commit/5d1ff99a9ac02b12ca2dd99b1e6f16f7db550793 which introduced an error in the Hessian feature calculation.
Reduce code duplication in Hessian feature calculation.

iarganda commented 7 years ago

Hello @maarzt ! Thanks a lot for noticing and correcting this error. What's up with the failed test? Are you still working on it?

maarzt commented 7 years ago

Hello @iarganda, the test failed because it couldn't find "bridge.png". I fixed this by adding a assumeNotNull. But I think it would be much better to add "bridge.png" and "bridge-expected.png" to the repository, so that the tests are not ignored by Travis anymore.

iarganda commented 7 years ago

I see. Those files are supposed to be created using the main method of BasicTest. I will put them there for simplicity.