Update Docker Hub

[joshmoore]

see:

• https://gitter.im/fiji/fiji?at=5cdeadc8ef853135c8d6cfdd
• https://github.com/fiji/dockerfiles/pull/8

Preparations for a push of new images to docker hub. cF:

I'll likely re-tag the existing images with something in case something has broken in the meantime.

cc: @olatarkowska @ctrueden @chigozienri

[joshmoore]

[jamoore@idr1-slot2 fiji-dockerfiles]$ for x in openjdk- oracle-jdk; do for y in 6 7; do docker pull fiji/fiji:fiji-$x$y; done; done
...
[jamoore@idr1-slot2 fiji-dockerfiles]$ for x in openjdk- oracle-jdk; do for y in 6 7; do docker tag fiji/fiji:fiji-$x$y fiji/fiji:fiji-$x$y-legacy; done; done
fiji/fiji                                                                    fiji-oracle-jdk7                        4f3616fe21bd        4 years ago         870MB
fiji/fiji                                                                    fiji-oracle-jdk7-legacy                 4f3616fe21bd        4 years ago         870MB
fiji/fiji                                                                    fiji-oracle-jdk6                        0e90cf008100        4 years ago         786MB
fiji/fiji                                                                    fiji-oracle-jdk6-legacy                 0e90cf008100        4 years ago         786MB
fiji/fiji                                                                    fiji-openjdk-6                          d960bb9254be        4 years ago         727MB
fiji/fiji                                                                    fiji-openjdk-6-legacy                   d960bb9254be        4 years ago         727MB
fiji/fiji                                                                    fiji-openjdk-7                          d9016df6262c        4 years ago         876MB
fiji/fiji                                                                    fiji-openjdk-7-legacy                   d9016df6262c        4 years ago         876MB
fiji/fiji                                                                    latest                                  d9016df6262c        4 years ago         876MB
[jamoore@idr1-slot2 fiji-dockerfiles]$ docker push fiji/fiji:fiji-openjdk-7-legacy
The push refers to repository [docker.io/fiji/fiji]
5f70bf18a086: Layer already exists
a584354f99fa: Layer already exists
e7ae6c2513a1: Layer already exists
e75d841cf7bb: Layer already exists
2e71f96ed7ae: Layer already exists
2998cc39c7a6: Layer already exists
d3feddf6984f: Layer already exists
f39162388155: Layer already exists
0ae9a0356259: Layer already exists
230b028ff243: Layer already exists
fiji-openjdk-7-legacy: digest: sha256:99bbb5cdbca29ad5b07fba5245fc0d13eec8884fa8b6be731222f77c5e6d5238 size: 4678

Note: Only pushed fiji-openjdk-7-legacy for the moment, since it is the only tag that will be overwritten by the update.

[joshmoore]

Last commit produces tags of the form:

docker tag fiji/fiji:fiji-openjdk-8 fiji/fiji:fiji-openjdk-8.20190517
docker tag fiji/fiji:fiji-openjdk-7 fiji/fiji:fiji-openjdk-7.20190517
docker push fiji/fiji:fiji-openjdk-8.20190517
docker push fiji/fiji:fiji-openjdk-7.20190517
docker push fiji/fiji:fiji-openjdk-8
docker push fiji/fiji:fiji-openjdk-7
docker tag fiji/fiji:fiji-openjdk-8 fiji/fiji:latest
docker tag fiji/fiji:fiji-openjdk-8 fiji/fiji:20190517
docker push fiji/fiji:latest
docker push fiji/fiji:20190517

[joshmoore]

Updated to use @ctrueden's suggestion of downloading: https://gitter.im/fiji/fiji?at=5cded2ed75d9a575a6fa4a95

[joshmoore]

Latest state is usable via:

[jamoore@idr1-slot2 fiji-dockerfiles]$ docker run --rm fiji/fiji:fiji-openjdk-8 --ij2 --headless --console --run demo.py 'name="foo"'
Hello foo

@olatarkowska: I'm thinking for the updates, one should build their own docker image, since otherwise runs won't be reproducible. I can add a build-arg though that will add update sites.

We're getting to the stage that I'd suggest deploying the openjdk-8 image as latest.

[ctrueden]

Thanks so much for working on this!

I'm no Docker expert, so am not qualified to review much of this. I support merging whenever you are confident things are working well.

One thing about openjdk8: it does not come bundled with JavaFX; the openjfx needs to be installed separately. So that will be an issue for all the Fiji plugins requiring JavaFX (there are several now). This concern might seem silly since JavaFX is a UI thing, and Docker is typically used headless, but A) there might be class loading issues, and B) I believe Fiji can run from Docker graphically over X11.

[joshmoore]

I support merging whenever you are confident things are working well.

I'll do a little more testing and get confirmation from @olatarkowska, then merge and push to Docker Hub. (Open to tag naming schemes beyond .${today} though)

openjfx needs to be installed separately

Makes sense. I'll likely try to tackle that in a follow-up.

Fiji can run from Docker graphically over X11.

I was thinking about adding in Xvfb by default, but perhaps that's an extra image. Likely another next step.

NB: I also think the image names can use some shortening.

(If anyone out there is following along, feel free to add opinions)

[ctrueden]

Should we also change the MAINTAINER, since Mark isn't actually the one maintaining this? I looked up that metadata field the other day, and it's deprecated in favor of LABEL, with rather ad hoc semantics, so I didn't say anything till now, but seeing all these logs where it's blasting the wrong MAINTAINER in all capital letters is kinda bothering me now. 😆

[joshmoore]

:+1: https://github.com/fiji/dockerfiles/issues/15 :wink:

[joshmoore]

I've pushed to Docker Hub. If everyone is on board, I'll merge this and update fiji/fiji:latest:

fiji-openjdk-8: digest: sha256:0be12c68f5a42b3f319ffce6111be0b097d9c36b1c6237e7b8eb1685b9488572 size: 3251

[joshmoore]

General :+1: from https://gitter.im/fiji/fiji?at=5ce40eef13e9854e33411e9f

Updating the fiji/fiji:latest tag. Enjoy all!